https://bugzilla.redhat.com/show_bug.cgi?id=2437659
--- Comment #2 from Ben Beasley <[email protected]> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is generated by rust2rpm, simplifying the review. Examples and tests requiring binary files not included in published crates are disabled, which is reasonable and well-documented. Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ You should not package the WASM-related features. You won’t need them, and they have unsatisfied dependencies. All subpackages need to be installable. Either add [features] hide = [ "ts-rs", "wasm-bindgen", "wasm", ] to rust2rpm.toml, noting the cautions about this approach in the rust2rpm.toml man page, or patch them out of Cargo.toml with "rust2rpm -p". - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/docx- rs-0.4.19/LICENSE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files OK: not a serious problem, due to reasonable rust2rpm design decisions - A couple of issues with the Summary field are correctly noted by rpmlint: rust-docx-rs.src: W: summary-not-capitalized docx file writer with Rust/WebAssembly. rust-docx-rs.src: W: summary-ended-with-dot docx file writer with Rust/WebAssembly. While rust2rpm has decent heuristics that produce an appropriate summary most of the time, this is one of those times where you should override it. Add to rust2rpm.toml: [package] summary = "A .docx file writer with Rust/WebAssembly" ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 437 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2437659-rust-docx-rs/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- docx-rs-devel , rust-docx-rs+default-devel , rust-docx-rs+image-devel , rust-docx-rs+ts-rs-devel , rust-docx-rs+wasm-devel , rust-docx- rs+wasm-bindgen-devel [x]: Package functions as described. (tests pass) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=142251379 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [-]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: This is just an rpmautospec macro expansion, and that advice is outdated anyway. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 6.6 starting (python version = 3.14.2, NVR = mock-6.6-1.fc43), args: /usr/libexec/mock/mock -r fedora-rawhide-aarch64 --no-cleanup-after --no-clean --plugin-option=tmpfs:keep_mounted=True --resultdir=/home/ben/fedora/review/2437659-rust-docx-rs/results install /home/ben/fedora/review/2437659-rust-docx-rs/results/rust-docx-rs+image-devel-0.4.19-1.fc45.noarch.rpm /home/ben/fedora/review/2437659-rust-docx-rs/results/rust-docx-rs+wasm-bindgen-devel-0.4.19-1.fc45.noarch.rpm /home/ben/fedora/review/2437659-rust-docx-rs/results/rust-docx-rs+ts-rs-devel-0.4.19-1.fc45.noarch.rpm /home/ben/fedora/review/2437659-rust-docx-rs/results/rust-docx-rs+wasm-devel-0.4.19-1.fc45.noarch.rpm /home/ben/fedora/review/2437659-rust-docx-rs/results/rust-docx-rs+default-devel-0.4.19-1.fc45.noarch.rpm /home/ben/fedora/review/2437659-rust-docx-rs/results/rust-docx-rs-devel-0.4.19-1.fc45.noarch.rpm Start(bootstrap): init plugins INFO: selinux enabled Finish(bootstrap): init plugins Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Mock Version: 6.6 INFO: Mock Version: 6.6 Start(bootstrap): chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start(bootstrap): cleaning package manager metadata Finish(bootstrap): cleaning package manager metadata INFO: Package manager dnf5 detected and used (fallback) Finish(bootstrap): chroot init Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin INFO: Package manager dnf5 detected and used (direct choice) Finish: chroot init INFO: installing package(s): /builddir/rust-docx-rs+image-devel-0.4.19-1.fc45.noarch.rpm /builddir/rust-docx-rs+wasm-bindgen-devel-0.4.19-1.fc45.noarch.rpm /builddir/rust-docx-rs+ts-rs-devel-0.4.19-1.fc45.noarch.rpm /builddir/rust-docx-rs+wasm-devel-0.4.19-1.fc45.noarch.rpm /builddir/rust-docx-rs+default-devel-0.4.19-1.fc45.noarch.rpm /builddir/rust-docx-rs-devel-0.4.19-1.fc45.noarch.rpm ERROR: Command failed: # /usr/bin/systemd-nspawn -q -M 273971aa6823426c8ccd0c6e762b31c2 -D /var/lib/mock/fedora-rawhide-aarch64-bootstrap/root -a --capability=cap_ipc_lock --bind=/tmp/mock-resolv.1uo6nho4:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/fedora-rawhide-aarch64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin '--setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007"' '--setenv=PS1=<mock-chroot> \s-\v\$ ' --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf5 --installroot /var/lib/mock/fedora-rawhide-aarch64/root/ --releasever 45 install /builddir/rust-docx-rs+image-devel-0.4.19-1.fc45.noarch.rpm /builddir/rust-docx-rs+wasm-bindgen-devel-0.4.19-1.fc45.noarch.rpm /builddir/rust-docx-rs+ts-rs-devel-0.4.19-1.fc45.noarch.rpm /builddir/rust-docx-rs+wasm-devel-0.4.19-1.fc45.noarch.rpm /builddir/rust-docx-rs+default-devel-0.4.19-1.fc45.noarch.rpm /builddir/rust-docx-rs-devel-0.4.19-1.fc45.noarch.rpm --setopt=deltarpm=False --setopt=allow_vendor_change=yes --allowerasing --setopt=tsflags=nocontexts Rpmlint ------- Checking: rust-docx-rs-devel-0.4.19-1.fc45.noarch.rpm rust-docx-rs+default-devel-0.4.19-1.fc45.noarch.rpm rust-docx-rs+image-devel-0.4.19-1.fc45.noarch.rpm rust-docx-rs+ts-rs-devel-0.4.19-1.fc45.noarch.rpm rust-docx-rs+wasm-devel-0.4.19-1.fc45.noarch.rpm rust-docx-rs+wasm-bindgen-devel-0.4.19-1.fc45.noarch.rpm rust-docx-rs-0.4.19-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpark0r7eh')] checks: 32, packages: 7 rust-docx-rs+default-devel.noarch: W: summary-not-capitalized docx file writer with Rust/WebAssembly. rust-docx-rs+image-devel.noarch: W: summary-not-capitalized docx file writer with Rust/WebAssembly. rust-docx-rs+ts-rs-devel.noarch: W: summary-not-capitalized docx file writer with Rust/WebAssembly. rust-docx-rs+wasm-bindgen-devel.noarch: W: summary-not-capitalized docx file writer with Rust/WebAssembly. rust-docx-rs+wasm-devel.noarch: W: summary-not-capitalized docx file writer with Rust/WebAssembly. rust-docx-rs.src: W: summary-not-capitalized docx file writer with Rust/WebAssembly. rust-docx-rs-devel.noarch: W: summary-not-capitalized docx file writer with Rust/WebAssembly. rust-docx-rs+default-devel.noarch: W: summary-ended-with-dot docx file writer with Rust/WebAssembly. rust-docx-rs+image-devel.noarch: W: summary-ended-with-dot docx file writer with Rust/WebAssembly. rust-docx-rs+ts-rs-devel.noarch: W: summary-ended-with-dot docx file writer with Rust/WebAssembly. rust-docx-rs+wasm-bindgen-devel.noarch: W: summary-ended-with-dot docx file writer with Rust/WebAssembly. rust-docx-rs+wasm-devel.noarch: W: summary-ended-with-dot docx file writer with Rust/WebAssembly. rust-docx-rs.src: W: summary-ended-with-dot docx file writer with Rust/WebAssembly. rust-docx-rs-devel.noarch: W: summary-ended-with-dot docx file writer with Rust/WebAssembly. 7 packages and 0 specfiles checked; 0 errors, 14 warnings, 37 filtered, 0 badness; has taken 0.5 s Source checksums ---------------- https://crates.io/api/v1/crates/docx-rs/0.4.19/download#/docx-rs-0.4.19.crate : CHECKSUM(SHA256) this package : 70395eb132dcc1761533e62c54878a9deb2b637863ecb52e9c5f66148616398e CHECKSUM(SHA256) upstream package : 70395eb132dcc1761533e62c54878a9deb2b637863ecb52e9c5f66148616398e Requires -------- rust-docx-rs-devel (rpmlib, GLIBC filtered): (crate(base64/default) >= 0.22.1 with crate(base64/default) < 0.23.0~) (crate(serde/default) >= 1.0.219 with crate(serde/default) < 2.0.0~) (crate(serde/derive) >= 1.0.219 with crate(serde/derive) < 2.0.0~) (crate(serde_json/default) >= 1.0.142 with crate(serde_json/default) < 2.0.0~) (crate(thiserror/default) >= 2.0.12 with crate(thiserror/default) < 3.0.0~) (crate(xml-rs) >= 0.8.27 with crate(xml-rs) < 0.9.0~) (crate(zip) >= 0.6.3 with crate(zip) < 0.7.0~) (crate(zip/deflate) >= 0.6.3 with crate(zip/deflate) < 0.7.0~) cargo rust-docx-rs+default-devel (rpmlib, GLIBC filtered): cargo crate(docx-rs) crate(docx-rs/image) rust-docx-rs+image-devel (rpmlib, GLIBC filtered): (crate(image) >= 0.25.6 with crate(image) < 0.26.0~) (crate(image/bmp) >= 0.25.6 with crate(image/bmp) < 0.26.0~) (crate(image/gif) >= 0.25.6 with crate(image/gif) < 0.26.0~) (crate(image/jpeg) >= 0.25.6 with crate(image/jpeg) < 0.26.0~) (crate(image/png) >= 0.25.6 with crate(image/png) < 0.26.0~) (crate(image/tiff) >= 0.25.6 with crate(image/tiff) < 0.26.0~) cargo crate(docx-rs) rust-docx-rs+ts-rs-devel (rpmlib, GLIBC filtered): (crate(ts-rs/default) >= 6.1.0 with crate(ts-rs/default) < 7.0.0~) cargo crate(docx-rs) rust-docx-rs+wasm-devel (rpmlib, GLIBC filtered): cargo crate(docx-rs) crate(docx-rs/image) crate(docx-rs/ts-rs) crate(docx-rs/wasm-bindgen) rust-docx-rs+wasm-bindgen-devel (rpmlib, GLIBC filtered): (crate(wasm-bindgen/default) >= 0.2.92 with crate(wasm-bindgen/default) < 0.3.0~) cargo crate(docx-rs) Provides -------- rust-docx-rs-devel: crate(docx-rs) rust-docx-rs-devel rust-docx-rs+default-devel: crate(docx-rs/default) rust-docx-rs+default-devel rust-docx-rs+image-devel: crate(docx-rs/image) rust-docx-rs+image-devel rust-docx-rs+ts-rs-devel: crate(docx-rs/ts-rs) rust-docx-rs+ts-rs-devel rust-docx-rs+wasm-devel: crate(docx-rs/wasm) rust-docx-rs+wasm-devel rust-docx-rs+wasm-bindgen-devel: crate(docx-rs/wasm-bindgen) rust-docx-rs+wasm-bindgen-devel Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2437659 Buildroot used: fedora-rawhide-aarch64 Active plugins: Shell-api, Generic Disabled plugins: SugarActivity, Perl, PHP, C/C++, Python, Ocaml, Haskell, R, fonts, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2437659 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202437659%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
