https://bugzilla.redhat.com/show_bug.cgi?id=2436366
--- Comment #3 from Neal Gompa <[email protected]> --- Initial spec review: > Source0: > https://code.forgejo.org/forgejo/runner/archive/v%{version}.tar.gz This should be restructured so that the tarball is properly named. Something like "%{url}/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz" You can see an example in Quickshell: https://src.fedoraproject.org/rpms/quickshell/blob/rawhide/f/quickshell.spec > Requires: git Does it require *all* of git or just git-core and a few other things? Also, even "git" would not be enough to ensure things like git-lfs are pulled in, right? > %setup -n runner -q -a1 > %autopatch -p1 Can't this be simplified to "%autosetup -C -a1 -p1"? > %doc examples README.md RELEASE-NOTES.md release-notes/757.md Is it always going to 757.md? Should you just include the release-notes folder entirely instead? > %attr(755, root, root) %{_bindir}/forgejo-runner > %config(noreplace) %attr(644, root, root) > %{_sysconfdir}/forgejo-runner/config.yml "root, root" is already default, you can use "-, -" here instead. > %config(noreplace) %attr(755, runner, runner) %{_sharedstatedir}/runner/ I don't love that the user+group and homedir are just called "runner". Can we call this "forgejo-runner" instead? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2436366 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202436366%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
