https://bugzilla.redhat.com/show_bug.cgi?id=2440706

Rodolfo Olivieri <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(rodolfo.olivieri3 |
                   |@gmail.com)                 |



--- Comment #8 from Rodolfo Olivieri <[email protected]> ---
Hi, Tobi! Thanks for taking a look at it, here's the updated version. 

Spec URL:
https://download.copr.fedorainfracloud.org/results/r0x0d/python-cyclopts/fedora-rawhide-x86_64/10167402-python-cyclopts/python-cyclopts.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/r0x0d/python-cyclopts/fedora-rawhide-x86_64/10167402-python-cyclopts/python-cyclopts-4.6.0-1.fc45.src.rpm

They have updated to version 4.6.0 in the meantime of this review, however, I
found out a couple of strange things while fixing the
`SETUPTOOLS_SCM_PRETEND_VERSION_FOR_CYCLOPTS` in the spec. For some reason,
directly adding SETUPTOOLS_SCM_PRETEND_VERSION_FOR_CYCLOPTS=%{version} does not
work as it should, but `SETUPTOOLS_SCM_PRETEND_VERSION_FOR=%{version}` works
fine... Not sure why the automated copr build above failed, but I have one that
worked previously.

* Working version without the FOR_%{DIST}:
https://download.copr.fedorainfracloud.org/results/r0x0d/python-cyclopts/fedora-rawhide-x86_64/10148988-python-cyclopts/builder-live.log.gz
* Failed version with the FOR_%{DIST}:
https://download.copr.fedorainfracloud.org/results/r0x0d/python-cyclopts/fedora-rawhide-x86_64/10167233-python-cyclopts/builder-live.log.gz

I've decided to take a different approach and patch the pyproject.toml directly
with the version, and while this is not the best approach for this, at least a
new build should be able for the automated service.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2440706

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202440706%23c8

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to