https://bugzilla.redhat.com/show_bug.cgi?id=2442941
Ben Beasley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #3 from Ben Beasley <[email protected]> --- I was considering reviewing this, but I see Benson has taken it. That’s great – thanks, Benson! I’ll go ahead and post the findings from my incomplete preliminary review as a supplement for Benson’s pending review. ===== Issues ===== - I’m happy to see that you offered the build-system patch upstream. Please add a comment to the spec file referencing https://github.com/Quantco/multiregex/pull/100 when you import the package. - Consider packaging CHANGELOG.rst as documentation. - Please remove the period at the end of the Summary. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description ===== Notes ===== - You are no longer required to explicitly BR python3-devel when using %pyproject_buildrequires; see https://pagure.io/packaging-committee/pull-request/1379 and https://pagure.io/packaging-committee/pull-request/1384. However, doing so is harmless and is not an error. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2442941 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202442941%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
