https://bugzilla.redhat.com/show_bug.cgi?id=2444639
--- Comment #3 from Maksym Hazevych <[email protected]> --- Thank you for the review! I've updated the package to properly use the LICENSE file that was already present in the source, as well as to include licenses of the bundled dependencies. To get the list of licenses I've modified the project's build script and ran it right after the commit of the last release. Here's the build script change: https://github.com/mks-h/flood/commit/16746a31082d702372bf8dcf3580c721abfad538 I'll try to upstream this once the package passes review. As for the automatic requires and provides, they aren't present in this package since the project doesn't distribute node_modules. Instead, the bundle is transformed and minified into chunks of JavaScript files under the assets directory (plus the entry-point in bin). Here's the provides of the binary rpm: flood = 4.13.0-3.fc45 Here's the requires of the binary rpm: /bin/sh /bin/sh /bin/sh /usr/bin/node nodejs rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1 The source RPM differs by only requiring this: rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 systemd-rpm-macros I've tried to add a Node.js require in %check, like documented: https://docs.fedoraproject.org/en-US/packaging-guidelines/Node.js/#_build_testing_in_check But since this isn't a library package, just requiring it makes it run the webserver (indefinitely). I've also noticed and fixed the use of %setup macro from downloading the npm source twice (for some reason I've been using '-b 0' without '-T', so I removed it). Last thing I changed, is I replaced the %autorelease macro with the manual release number, since my commit history is not a reliable way to tell how many builds I released on COPR. I can change it back to %autorelease before the package get its own Fedora Package Sources repo, if absolutely necessary. BTW, is it fine if the release number skips e.g. from 1 to 3 because of a commit that wasn't used to actually release a build? Updated spec file: https://download.copr.fedorainfracloud.org/results/mks-h/Flood/fedora-43-x86_64/10198757-flood/flood.spec Updated SRPM: https://download.copr.fedorainfracloud.org/results/mks-h/Flood/fedora-43-x86_64/10198757-flood/flood-4.13.0-4.fc43.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2444639 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202444639%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
