https://bugzilla.redhat.com/show_bug.cgi?id=2444940



--- Comment #3 from Peter Lemenkov <[email protected]> ---
(In reply to Benson Muite from comment #2)

Thanks for starting reviewing it!

> Comments:
> a) Documentation is not build becuase:
> https://github.com/jelly-beam/rebar3_ex_doc
> has yet to be packaged. Not blocking.

Unfortunately yes. But we'll eventually package it as well. 

> b) Tests do not seem to run:
> ===> Compiling recon
> ===> Performing EUnit tests...
> ======================== EUnit ========================
> file "recon.app"
>   application 'recon'
>     module 'recon'
>     module 'recon_alloc'
>     module 'recon_lib'
>     module 'recon_map'
>     module 'recon_rec'
>     module 'recon_trace'
>     [done in 0.004 s]
>   [done in 0.005 s]
> module 'recon_SUITE'
> module 'recon_alloc_SUITE'
> module 'recon_lib_SUITE'
> module 'recon_rec_SUITE'
> module 'records1'
> module 'records2'
>   There were no tests to run.
> 
> Not blocking, but any way to fix this?

These are so-called Eunit-tests. Erlang ecosystem has a two separate testing
frameworks - eunit and common_test. We cannot tell which one is available so we
try to run both consequently. This project does not have eunit tests therefore
this message. However later we run a common_test suite:

```
===> Running Common Test suites...
Common Test starting (cwd is
/builddir/build/BUILD/erlang-recon-2.5.6-build/recon-2.5.6)
CWD set to:
"/builddir/build/BUILD/erlang-recon-2.5.6-build/recon-2.5.6/_build/test/logs/[email protected]_23.19.14"
TEST INFO: 1 test(s), 35 case(s) in 4 suite(s)
Testing lib.recon: Starting test, 35 test cases
%%% recon_SUITE: ...............Testing lib.recon: *** SKIPPED test case 16 of
35 ***
%%% recon_SUITE ==> files: SKIPPED
%%% recon_SUITE ==> {tc_user_skip,"files can no longer be listed in OTP-21 and
above"}
.....
%%% recon_alloc_SUITE: .........
%%% recon_lib_SUITE: .
...
..
%%% recon_rec_SUITE: ..
Testing lib.recon: TEST COMPLETE, 34 ok, 0 failed, 1 skipped of 35 test cases
Updating
/builddir/build/BUILD/erlang-recon-2.5.6-build/recon-2.5.6/_build/test/logs/index.html
... done
Updating
/builddir/build/BUILD/erlang-recon-2.5.6-build/recon-2.5.6/_build/test/logs/all_runs.html
... done
```

> c) Any hope of moving:
> https://fedoraproject.org/wiki/User:Peter/Erlang_Packaging_Guidelines
> to the packaging guildelines?

I'll start working on it.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2444940

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202444940%23c3

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to