Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=696345 --- Comment #3 from Severin Gehwolf <[email protected]> 2011-04-14 11:29:01 EDT --- Thanks for the review. (In reply to comment #2) > === Issues === > 1. Install epl file as %doc. > 2. Remove %clean section and cleaning of buildroot from beginning of %install > 3. Use %{buildroot} and $RPM_BUILD_ROOT consistently. All fixed. > 4. Are you sure that you need to BR eclipse-cdt? It is not put on the pdebuild > path so it should not be needed. Isn't needed. Fixed. > 5. Why do you replace qualifier manually in %prep? Isn't it done by pdebuild > automatically? Good point. Doesn't seem to be needed. Let me know if there are other issues. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
