https://bugzilla.redhat.com/show_bug.cgi?id=2453438
[email protected] changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #5 from [email protected] --- I tried it out, it works! This is my first rust package to review so bear with me as I look at. https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/ This looks like it may have come from rust2rpm. The src vendor package looked custom, so i did a rust2rpm -t fedora -V auto amdgpu_top and it automagically created the source and vendor. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* Apache License 2.0", "BSD 0-Clause License", "*No copyright* MIT License", license just has MIT now. The hard part will be going through the licensecheck.txt and identifying possible issues. I was surprised how much vendor things was pulled in for essentially a replacement for btop. could this be pared down? Since so much is bundled, i am wondering about this part of the guidlines 'all bundled crate dependencies MUST be declared with virtual Provides in the format Provides: bundled(crate($crate)) = $version' Is this being done ? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2453438 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202453438%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
