https://bugzilla.redhat.com/show_bug.cgi?id=1816301
Mark Olesen <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mark.olesen@keysi | |ght.com) | --- Comment #61 from Mark Olesen <[email protected]> --- (In reply to Phil Wyett from comment #60) > Hi, > > Builds are looking OK. I would draw your attention to the attachments > uploaded by Benson that need attention. Hi Phil, I took a look through the copyright and rpmlint files attached by Benson and not really sure how relevant they still are. The openfoam-rpmlintrc should have been part of the build and it states a bunch of filters (eg, the tutorials frequently have a 0.orig/ directory with pristine restart boundary conditions that are copied to 0/ upon execution). The stripping of files is definitely missing though. Probably since we use a custom 'bin/tools/install-platform' script instead of 'make install' (we don't have a Makefile. I guess this is where this type of thing should happen? For the copyright/license issues: most seem to be on boilerplate code templates where people would normally manually add their own. Not really convinced about most of the flagged "spelling issues". Which of the issues are the biggest ones to tackle first? Cheers, /mark -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1816301 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%201816301%23c61 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
