https://bugzilla.redhat.com/show_bug.cgi?id=2476902



--- Comment #5 from [email protected] ---
Spec URL: https://trix.fedorapeople.org/python-piper-tts.spec
SRPM URL: https://trix.fedorapeople.org/python-piper-tts-1.4.2-1.fc45.src.rpm

>> Source0:        %{url}/archive/refs/tags/v%{version}.tar.gz

> This should be "%{url}/archive/v%{version}/piper1-gpl-%{version}.tar.gz

Done.

>> # No debug package
>> %global debug_package %{nil}

> Why? This sounds like our compiler flags aren't propagating properly...

Needed more configury. In pyproject.toml, 

[tool.scikit-build]
wheel.packages = ["src/piper"]
build.verbose = true
cmake.build-type = "RelWithDebInfo"
install.strip = false
logging.level = "INFO"

I believe the install.strip = false, is what was need, RelWithDebInfo I already
had the first time.

>> %description
>> %{summary}

> This needs a trailing period.

Done

>> %autosetup -p1 -n piper1-gpl-%{version}

> FYI, you can simplify this to "%autosetup -C -p1"

Leaving as-is.

>> %{python3_sitearch}/piper_tts-%{version}.dist-info

> Please add a trailing slash here, so RPM knows that it should always be a 
> directory.

done, and in the piper dir


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2476902

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202476902%23c5

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to