https://bugzilla.redhat.com/show_bug.cgi?id=2468635
--- Comment #3 from wojnilowicz <[email protected]> --- > Comments: > a) Please change: > Source: %{url}/archive/refs/tags/v%{version}.tar.gz > to > Source: %{url}/archive/v%{version}/wl-kbptr-%{version}.tar.gz > See > https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > #_git_tags Done. > b) Do add pixman-devel as a build dependency: > https://github.com/moverest/wl-kbptr#dependencies > It seems to be pulled in by another package, but in case this no longer > happens, > it is good to list it explicitly. Done. > c) The package seems to be under GPL-3.0-only, but raised an issue upstream > to check: > https://github.com/moverest/wl-kbptr/issues/90 I wasn't aware of this -only and -or-later. Thanks for pointing that out. I added a comment about it. > d) Files in https://github.com/moverest/wl-kbptr/tree/main/protocol > seem to be under NTP license, raised issue about adding license file to main > repository: > https://github.com/moverest/wl-kbptr/issues/91 Added the license through a PR. [fedora-review-service-build] -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2468635 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202468635%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
