https://bugzilla.redhat.com/show_bug.cgi?id=2453414
--- Comment #9 from Kurtis <[email protected]> --- Spec URL: https://download.copr.fedorainfracloud.org/results/kmarinos/lemonade-server/srpm-builds/10460803/lemonade-server.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/kmarinos/lemonade-server/srpm-builds/10460803/lemonade-server-10.4.0-1.fc45.src.rpm Updated package to v10.4.0 Systemd Service File Renamed: - Renamed upstream service file from lemonade-server.service to lemond.service - Service file was no longer being installed by cmake so I added a manual install in %install - Updated %post, %preun, %postun scriptlets to reference lemond.service and updated %files to reference lemond.service Fixed %check Section: - I took a look at the --with-check option while building, and investigated the py tests. From my understanding it appears that the upstream tests are integration tests that require a running lemonade-server instance, the binary at the upstream dev build path (build/lemonade-server), and GPU hardware. I documented this in a comment within the check section of the spec file. The tests cannot run in a build environment - Replaced %pytest macro with direct python3 -m pytest call, the %pytest macro was not expanding correctly when troubleshooting. - Added python3-openai to conditional BuildRequires required by the tests. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2453414 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202453414%23c9 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
