https://bugzilla.redhat.com/show_bug.cgi?id=2389251
--- Comment #8 from Artur Frenszek-Iwicki <[email protected]> --- > The Readme also has a very good breakdown of these, can maybe point to it and > add it in the `%license`? I think adding `debian/copyright` as `%license` is a better idea, as that file actually contains the relevant license texts. > [!]: License file installed when any subpackage combination is installed. > (Technically fails when only `davegnukem-data` is installed) Moved all the license texts to the -data subpackage. > > Backport some upstream improvements to the Makefile > Do you have some links to those? Added. > > Requires: hicolor-icon-theme > Can add the standard note that this is needed because for directory ownership I guess I could, but then, it's a rather standard usage and I'm not a fan of redundant comments. > > README.md says simply "MIT license or GPL". > Can raise the issue to make it more explicit? Opened an issue upstream: https://github.com/davidjoffe/dave_gnukem/issues/211 In the meantime, changed the license tag from "GPL-2.0-or-later or MIT" to "MIT or GPL-2.0-only or GPL-3.0-only" to better reflect what's in the debian/copyright file. spec: https://suve.fedorapeople.org/review/davegnukem-1.0.3-3/davegnukem.spec srpm: https://suve.fedorapeople.org/review/davegnukem-1.0.3-3/davegnukem-1.0.3-3.fc44.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=145636415 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2389251 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202389251%23c8 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
