https://bugzilla.redhat.com/show_bug.cgi?id=2390526
--- Comment #10 from Artur Frenszek-Iwicki <[email protected]> --- > Providence of patches please? Both patches are original, written for the Fedora package. > > While stb is unbundled, it's a static library, so it's still included in > > the License tag. > Well, so is `nlohmann_json` right? Good catch, I'll add it to the license tag. > > %global httplib_bundled 0 > Can make this a %bcond instead? Uhh, I guess I could, though I never used bconds, so I'd have to do some reading on those. > > -DCMAKE_POLICY_VERSION_MINIMUM=3.5 > Can raise the issue to upstream? Sure. > > sed -e 's|^#include "3rdparty/stb/|#include "stb/|g' -i > > src/augs/image/image.cpp > This looks like something that can be fixed in upstream by moving the > `target_include_directories` one layer up. Can propose to upstream? I know next to nothing about CMake, but I can check if that works or not. > > -DARCHITECTURE=native > Oh boy that flag does some vodoo. Can you check [1] to see if you should > conditionalize it? It does some voodoo, yes. "native" is the non-voodoo option - it should not set any extra compiler switches or perform any other magic. Originally, upstream did not support "native"; I've sent this in a patch. > > -DBUILD_UNIT_TESTS=OFF > Can add a comment on why? Never tried those. I can look into them. > Alternatively, what's the deal with cmake/steam_integration/CMakeLists.txt? This looks like a helper target that upstream uses for generating AppImages for the Steam version: https://store.steampowered.com/app/2660970/Hypersomnia/ > > BSD-2-Clause > Why it was added is not explained. Leftover from previous versions, where it was not possible to build against system-provided LZ4. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2390526 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202390526%23c10 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
