https://bugzilla.redhat.com/show_bug.cgi?id=2477712

Ben Beasley <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
             Status|ASSIGNED                    |POST



--- Comment #5 from Ben Beasley <[email protected]> ---
Thanks! The package is APPROVED by inspection of the spec-file diff, below. All
defects are corrected and suggestions are implemented, and neither
fedora-review nor rpmlint indicates any new issues.


---
../../2477712-json-schema-validator/srpm-unpacked/json-schema-validator.spec   
    2026-
05-14 01:00:00.000000000 +0100
+++ srpm-unpacked/json-schema-validator.spec    2026-05-18 01:00:00.000000000
+0100
@@ -6,8 +6,12 @@
 Release:        %autorelease
 Summary:        Modern C++ JSON schema validator

-License:        MIT
+# The entire source is MIT; the header-only json library dependency is
+# (MIT AND CC0-1.0), where the CC0-1.0 comes from bundled hedley.
+License:        MIT AND CC0-1.0
+SourceLicense:  MIT
 URL:            https://github.com/pboettch/json-schema-validator
+VCS:            git:%{url}.git
 Source:         %{url}/archive/%{version}/%{name}-%{version}.tar.gz

 # See https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval
@@ -15,8 +19,8 @@
 BuildSystem:    cmake
 BuildOption(conf): -DJSON_VALIDATOR_BUILD_EXAMPLES:BOOL=OFF

-BuildRequires:  cmake(nlohmann_json)
 BuildRequires:  gcc-c++
+BuildRequires:  json-static

 %description
 This is a C++ library for validating JSON documents based on a JSON Schema
@@ -24,6 +28,7 @@

 %package        devel
 Summary:        Development files for json-schema-validator
+License:        MIT
 Requires:       %{name}%{?_isa} = %{version}-%{release}
 Requires:       json-devel%{?_isa}

@@ -35,11 +40,12 @@
 %autosetup

 %files
-%doc README.md
+%doc ChangeLog.md README.md
 %license LICENSE
 %{_libdir}/libnlohmann_json_schema_validator.so.2{,.*}

 %files devel
+%doc example/
 %{_includedir}/nlohmann/json-schema.hpp
 %{_libdir}/cmake/nlohmann_json_schema_validator/
 %{_libdir}/libnlohmann_json_schema_validator.so


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2477712

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202477712%23c5

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to