https://bugzilla.redhat.com/show_bug.cgi?id=2478132
--- Comment #5 from Ben Beasley <[email protected]> --- (In reply to Jerry James from comment #4) > This package is APPROVED. Thank you for the review! https://release-monitoring.org/project/231475/ > One note: the file src/libLfunction/mpreal.h is dual-licensed nonfree and > GPL-3.0-or-later. It is only used in the build if precision is "multiple". > Since precision is currently set to "double", there is no issue, but I > wonder if the spec file should contain a comment noting that choosing > "multiple" would affect the license of the package. This is a very good catch! I will document these details in the spec file, and remove the header in %prep for builds where it should not be used. In fact, “MPFR C++,” a C++ wrapper over MPFR, is a header-only library, and mpreal.h is the whole thing, so this would need to be unbundled or documented as a case of bundling if we ever did a multi-precision build. I doubt we will ever build this for anything other than double precision in Fedora proper. > (Also, note that comment A in that file is incorrect; mpfr is licensed > LGPL-3.0-or-later, not any form of GPL.) MPFR is LGPL, but the “MPFR C++” wrapper really is GPL: http://www.holoborodko.com/pavel/mpfr/#license -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2478132 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202478132%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
