https://bugzilla.redhat.com/show_bug.cgi?id=2481782



--- Comment #2 from Jitka Plesnikova <[email protected]> ---
Source file is ok
Summary is ok

License
FIX: The license should be Artistic-2.0. It is mention in README

Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are ok
FIX: Please add build-requires
     perl(Exporter) - lib/Text/JSContact.pm:19
     perl(HTTP::Request) - t/cyrus-carddav.t:8
     perl(lib) - t/basic.t:8

$ rpm -qp --requires perl-Text-JSContact-0.01-1.fc45.noarch.rpm | sort | uniq
-c | grep -v rpmlib
      1 perl(Encode)
      1 perl(Exporter)
      1 perl(JSON)
      1 perl-libs
      1 perl(MIME::Base64)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Text::VCardFast) >= 0.06
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Text-JSContact-0.01-1.fc45.noarch.rpm | sort | uniq
-c
      1 perl(Text::JSContact) = 0.01
      1 perl-Text-JSContact = 0.01-1.fc45
Binary provides are Ok.

$ rpmlint ./perl-Text-JSContact*
========================================== rpmlint session starts
======================================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

perl-Text-JSContact.noarch: E: spelling-error ('vCard', 'Summary(en_US) vCard
-> v Card, card')
perl-Text-JSContact.noarch: E: spelling-error ('vCard', '%description -l en_US
vCard -> v Card, card')
perl-Text-JSContact.src: E: spelling-error ('vCard', 'Summary(en_US) vCard -> v
Card, card')
perl-Text-JSContact.src: E: spelling-error ('vCard', '%description -l en_US
vCard -> v Card, card')
==== 2 packages and 1 specfiles checked; 4 errors, 0 warnings, 8 filtered, 4
badness; has taken 0.3 s ==
Rpmlint is ok

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items and provide a new spec file.

Resolution:
NOT Approved


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2481782

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202481782%23c2

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to