https://bugzilla.redhat.com/show_bug.cgi?id=2482689



--- Comment #3 from Neal Gompa <[email protected]> ---
Initial spec review:

> SourceLicense:  GPL-3.0-or-later
> License:        GPL-3.0-or-later

The latter tag needs to be the "compiled" license, with all statically linked
dependencies...

Cf.
https://docs.fedoraproject.org/en-US/legal/license-field/#_no_effective_license_analysis

> Source0:        %{url}/archive/refs/tags/v%{version}.tar.gz

Please use "%{url}/archive/v%{version}/%{name}-%{version}.tar.gz".

Cf.
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags

> %autosetup -n rebuilderd-%{version} -p1

You could alternatively use "%autosetup -C -p1" if you don't need EPEL support.

> %{_mandir}/man1/rebuilderd.1.*

This should be ".1*", since you cannot expect an extension suffix.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2482689

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202482689%23c3

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to