https://bugzilla.redhat.com/show_bug.cgi?id=2445458
Benson Muite <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #13 from Benson Muite <[email protected]> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 3", "*No copyright* GNU Lesser General Public License, Version 3", "*No copyright* GNU Lesser General Public License, Version 3 and/or Public domain", "*No copyright* Creative Commons CC0 1.0", "GNU General Public License v3.0 or later and/or GNU Lesser General Public License, Version 3", "GNU General Public License v3.0 or later". 1166 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/python-telegram-bot/temp/review-python- telegram-bot/srpm-unpacked/review-python-telegram-bot/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.14, /usr/lib/python3.14/site-packages [-]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 14189 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-python-telegram-bot [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [!]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-python-telegram-bot-22.7-1.fc45.noarch.rpm python3-python-telegram-bot+callback-data-22.7-1.fc45.noarch.rpm python3-python-telegram-bot+ext-22.7-1.fc45.noarch.rpm python3-python-telegram-bot+http2-22.7-1.fc45.noarch.rpm python3-python-telegram-bot+job-queue-22.7-1.fc45.noarch.rpm python3-python-telegram-bot+passport-22.7-1.fc45.noarch.rpm python3-python-telegram-bot+rate-limiter-22.7-1.fc45.noarch.rpm python3-python-telegram-bot+socks-22.7-1.fc45.noarch.rpm python3-python-telegram-bot+webhooks-22.7-1.fc45.noarch.rpm python-telegram-bot-22.7-1.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmphln5_fri')] checks: 32, packages: 10 python-telegram-bot.src: E: spelling-error ('submodule', '%description -l en_US submodule -> sub module, sub-module, module') python3-python-telegram-bot.noarch: E: spelling-error ('submodule', '%description -l en_US submodule -> sub module, sub-module, module') 10 packages and 0 specfiles checked; 2 errors, 0 warnings, 117 filtered, 2 badness; has taken 2.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.9.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 9 python3-python-telegram-bot.noarch: E: spelling-error ('submodule', '%description -l en_US submodule -> sub module, sub-module, module') 9 packages and 0 specfiles checked; 1 errors, 0 warnings, 113 filtered, 1 badness; has taken 1.3 s Source checksums ---------------- https://github.com/python-telegram-bot/python-telegram-bot/releases/download/v22.7/python_telegram_bot-22.7.tar.gz : CHECKSUM(SHA256) this package : 784b59ea3852fe4616ad63b4a0264c755637f5d725e87755ecdee28300febf61 CHECKSUM(SHA256) upstream package : 784b59ea3852fe4616ad63b4a0264c755637f5d725e87755ecdee28300febf61 https://github.com/python-telegram-bot/python-telegram-bot/releases/download/v22.6/python_telegram_bot-22.6.tar.gz.sha1 : CHECKSUM(SHA256) this package : 832a8add1265df04b1882ea15f82fdd1c139ce66e528070e0745f665d82a4547 CHECKSUM(SHA256) upstream package : 832a8add1265df04b1882ea15f82fdd1c139ce66e528070e0745f665d82a4547 https://github.com/python-telegram-bot/python-telegram-bot/releases/download/v22.6/python_telegram_bot-22.6.tar.gz.sigstore.json : CHECKSUM(SHA256) this package : 43179184d2ce7e563d8216be3883afd02a2061da6476a78b113d1d817465e2a1 CHECKSUM(SHA256) upstream package : 43179184d2ce7e563d8216be3883afd02a2061da6476a78b113d1d817465e2a1 Requires -------- python3-python-telegram-bot (rpmlib, GLIBC filtered): (python3.14dist(httpx) < 0.29~~ with python3.14dist(httpx) >= 0.27) python(abi) python3.14dist(httpcore) python3-python-telegram-bot+callback-data (rpmlib, GLIBC filtered): python(abi) python3-python-telegram-bot python3.14dist(cachetools) python3-python-telegram-bot+ext (rpmlib, GLIBC filtered): (python3.14dist(aiolimiter) < 1.3~~ with python3.14dist(aiolimiter) >= 1.1) (python3.14dist(apscheduler) < 3.12~~ with python3.14dist(apscheduler) >= 3.10.4) (python3.14dist(tornado) >= 6.5 with python3.14dist(tornado) < 7) python(abi) python3-python-telegram-bot python3.14dist(cachetools) python3-python-telegram-bot+http2 (rpmlib, GLIBC filtered): python(abi) python3-python-telegram-bot python3.14dist(httpx) python3.14dist(httpx[http2]) python3-python-telegram-bot+job-queue (rpmlib, GLIBC filtered): (python3.14dist(apscheduler) < 3.12~~ with python3.14dist(apscheduler) >= 3.10.4) python(abi) python3-python-telegram-bot python3-python-telegram-bot+passport (rpmlib, GLIBC filtered): ((python3.14dist(cryptography) < 3.4 or python3.14dist(cryptography) > 3.4) with (python3.14dist(cryptography) < 3.4.1 or python3.14dist(cryptography) > 3.4.1) with (python3.14dist(cryptography) < 3.4.2 or python3.14dist(cryptography) > 3.4.2) with (python3.14dist(cryptography) < 3.4.3 or python3.14dist(cryptography) > 3.4.3) with python3.14dist(cryptography) >= 39.0.1) python(abi) python3-python-telegram-bot python3.14dist(cffi) python3-python-telegram-bot+rate-limiter (rpmlib, GLIBC filtered): (python3.14dist(aiolimiter) < 1.3~~ with python3.14dist(aiolimiter) >= 1.1) python(abi) python3-python-telegram-bot python3-python-telegram-bot+socks (rpmlib, GLIBC filtered): python(abi) python3-python-telegram-bot python3.14dist(httpx) python3.14dist(httpx[socks]) python3-python-telegram-bot+webhooks (rpmlib, GLIBC filtered): (python3.14dist(tornado) >= 6.5 with python3.14dist(tornado) < 7) python(abi) python3-python-telegram-bot Provides -------- python3-python-telegram-bot: python-python-telegram-bot python3-python-telegram-bot python3.14-python-telegram-bot python3.14dist(python-telegram-bot) python3dist(python-telegram-bot) python3-python-telegram-bot+callback-data: python-python-telegram-bot+callback-data python3-python-telegram-bot+callback-data python3.14-python-telegram-bot+callback-data python3.14dist(python-telegram-bot[callback-data]) python3dist(python-telegram-bot[callback-data]) python3-python-telegram-bot+ext: python-python-telegram-bot+ext python3-python-telegram-bot+ext python3.14-python-telegram-bot+ext python3.14dist(python-telegram-bot[ext]) python3dist(python-telegram-bot[ext]) python3-python-telegram-bot+http2: python-python-telegram-bot+http2 python3-python-telegram-bot+http2 python3.14-python-telegram-bot+http2 python3.14dist(python-telegram-bot[http2]) python3dist(python-telegram-bot[http2]) python3-python-telegram-bot+job-queue: python-python-telegram-bot+job-queue python3-python-telegram-bot+job-queue python3.14-python-telegram-bot+job-queue python3.14dist(python-telegram-bot[job-queue]) python3dist(python-telegram-bot[job-queue]) python3-python-telegram-bot+passport: python-python-telegram-bot+passport python3-python-telegram-bot+passport python3.14-python-telegram-bot+passport python3.14dist(python-telegram-bot[passport]) python3dist(python-telegram-bot[passport]) python3-python-telegram-bot+rate-limiter: python-python-telegram-bot+rate-limiter python3-python-telegram-bot+rate-limiter python3.14-python-telegram-bot+rate-limiter python3.14dist(python-telegram-bot[rate-limiter]) python3dist(python-telegram-bot[rate-limiter]) python3-python-telegram-bot+socks: python-python-telegram-bot+socks python3-python-telegram-bot+socks python3.14-python-telegram-bot+socks python3.14dist(python-telegram-bot[socks]) python3dist(python-telegram-bot[socks]) python3-python-telegram-bot+webhooks: python-python-telegram-bot+webhooks python3-python-telegram-bot+webhooks python3.14-python-telegram-bot+webhooks python3.14dist(python-telegram-bot[webhooks]) python3dist(python-telegram-bot[webhooks]) Diff spec file in url and in SRPM --------------------------------- --- /home/fedora-packaging/reviews/python-telegram-bot/temp/review-python-telegram-bot/srpm-unpacked/python-telegram-bot.spec 2026-05-31 09:45:20.320718590 +0300 +++ /home/fedora-packaging/reviews/python-telegram-bot/temp/review-python-telegram-bot/srpm-unpacked/review-python-telegram-bot/srpm-unpacked/python-telegram-bot.spec 2026-05-31 03:00:00.000000000 +0300 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.8.4) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + Name: python-telegram-bot Version: 22.7 @@ -68,3 +78,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Sun May 31 2026 John Doe <[email protected]> - 22.7-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -n python-telegram-bot Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Python, Generic Disabled plugins: Java, SugarActivity, fonts, Ocaml, C/C++, R, PHP, Haskell, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Please change BuildOption(generate_buildrequires): -x callback-data,ext,http2,job-queue,passport,rate-limiter,socks,tests,webhooks to BuildOption(generate_buildrequires): -x callback-data,ext,http2,job-queue,passport,rate-limiter,socks,webhooks Without this change the package does not build. Got patches from updated SRPM at: https://peter.fedorapeople.org/packages/ b) Packages to do signature checks are not yet in Fedora. c) Upstream has indicated directory install location cannot be changed: https://github.com/python-telegram-bot/python-telegram-bot/issues/5251 just need to monitor it. d) Approved. Please fix (a) before import. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2445458 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202445458%23c13 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
