https://bugzilla.redhat.com/show_bug.cgi?id=2468312
--- Comment #40 from Cristian Le <[email protected]> --- Various comments on the current state - The bundling approach of pugixml is dubious. Please add `Provides: bundled()` accordingly and provide an issue/PR about debundling in upstream. You said that you would be contacting upstream about several issues, but I do not see any such activities and especially none that are tracked in the spec file - The bundling of the svgs is quite questionable, and it will slow down the review to figure out its providence, licensing, etc. - All patches do not have providence or explanation to what they are trying to do - Please separate the BuildRequires to be individual lines and comment where it is relevant, e.g. test dependencies, doc building dependencies etc. - The current `pwsafe` version in Fedora is `0.20.0`, please use that for the Obsoletes - Consider de-globing the mandir to make sure it would not be lost - What is the deal with `snapshot.patch`, what were you trying to do? - Please avoid blindly `sed`. Instead create patches for those and discuss with upstream to include them in some form The whole handling of oofice and pandoc is creating more complications than good, and this is causing the only major blocker right now. Consider removing it, markdown is perfectly readable documentation that does not need a separate application to render. Try to focus on resolving these issues without making too many other changes, because it is very close to being ready to be approved. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2468312 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202468312%23c40 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
