https://bugzilla.redhat.com/show_bug.cgi?id=2469062



--- Comment #2 from Benson Muite <[email protected]> ---

> 
> 
> 1. False positive Unowned python directories are false postive. 
> 2. Optional - could use "-x dev" to get the nose requirement.
> 

Prefer to add requirement directly so that extra development dependencies
are not installed.  Nose should not be used on Fedora, but nose2 is
allowed.

> 
> Comments 
> 
> 1. Why %pyproject_save_files -L and not %pyproject_save_files -l 
> 
> Better to fail if it goes missing is always my thinking.
> 

Thanks. Fixed.

> 2. Some of the line spacing is erratic. 2 lines between build and install
> but only 1 between check and changelog

Have used 1 line except before the build section.

spec: https://fed500.fedorapeople.org/python-asdl.spec
srpm: https://fed500.fedorapeople.org/python-asdl-0.1.5-1.fc43.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2469062

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202469062%23c2

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to