https://bugzilla.redhat.com/show_bug.cgi?id=2418386
Dominik 'Rathann' Mierzejewski <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(dominik@greysecto | |r.net) | --- Comment #3 from Dominik 'Rathann' Mierzejewski <[email protected]> --- (In reply to Andreas Haupt from comment #2) > I reviewed the ticket. Two spelling errors found: > > "macromolecule" is a false positive and can be ignored (see: > https://en.wikipedia.org/wiki/Macromolecule) Ack. > "aminoacid" should be fixed ("amino acid"), I guess (although it's just > copied from the original description). Fixed. > And as the final package requires perl(Scalar::Util) it should also be a > BuildRequires in the "%if %{with check}" block. It was in the unconditional BRs list, but anyway, I dropped the conditional around %check. > Otherwise the package looks fine. Thanks for the review! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2418386 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202418386%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
