https://bugzilla.redhat.com/show_bug.cgi?id=2487448
--- Comment #6 from Tadej Janež <[email protected]> --- Thanks for a quick review, Ben! (In reply to Ben Beasley from comment #2) > > ===== Notes (no change required for approval) ===== > > - The explicit > > BuildRequires: python3-devel > > is not required whenn you have %pyproject_buildrequires (or BuildSystem: > pyproject); however, it does no harm. See > https://pagure.io/packaging-committee/pull-request/1379, > https://pagure.io/packaging-committee/pull-request/1384. > > - You might choose to use the new pyproject long options; > > %pyproject_save_files --assert-license pytest_socket > > instead of > > %pyproject_save_files -l pytest_socket > > This makes the spec file a bit easier to understand, but isn’t supported in > EPEL9/10 branches. Thanks for both suggestions! I implemented them in the initial import: https://src.fedoraproject.org/rpms/python-pytest-socket/c/a161056fc201e3906cdb47c4093b2beed21e4903?branch=rawhide -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2487448 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202487448%23c6 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
