https://bugzilla.redhat.com/show_bug.cgi?id=2478126
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] Flags| |fedora-review? Assignee|[email protected] |[email protected] --- Comment #2 from Fabio Valentini <[email protected]> --- Some more comments after discussion on Matrix: It looks like your spec file is based on very old (Rust) packaging practices. Some of the things done in the linked .spec file are quite outdated, and are now covered by either "SHOULD NOT" or "MUST NOT" rules in the Rust packaging guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/ I would recommend to take a look and make changes based on the template for packages like this: https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_non_crate_rust_project Issues include: 1. The package SHOULD use rpmautospec instead of managing Release and %changelog manually. https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_release_tag https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs 2. The Source URL is not in line with guidelines for tarballs from GitHub: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags Should be: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz 3. The package MUST NOT specify BuildRequires for Rust crates manually: > packages for projects that build Rust code with cargo MUST use dynamically > generated BuildRequires https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_dynamically_generated_buildrequires_for_crate_dependencies 3. The license tag does not reflect statically linked Rust dependencies: https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_license_tags 4. This __brp_mangle_shebangs hack should not be necessary: > %global __brp_mangle_shebangs_exclude_from ^.*\.rs$ I'm not sure why you added this, but the package doesn't install any *.rs files, so this should be entirely unnecessary. I'm not sure why this is present. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2478126 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202478126%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
