https://bugzilla.redhat.com/show_bug.cgi?id=2486075

Ben Beasley <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Ben Beasley <[email protected]> ---
> # FIXME: no license files detected

You have to actually fix this.

https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

I opened https://gitlab.gnome.org/World/Rust/sourceview5-rs/-/merge_requests/30
to fix the problem upstream. Meanwhile, you can look in .cargo_vcs_info.json to
get the git commit corresponding to the release
(264a23088491a5c1812e90b41b4926341ff8fe58 for 0.11.0), and then add
https://gitlab.gnome.org/World/Rust/sourceview5-rs/-/raw/264a23088491a5c1812e90b41b4926341ff8fe58/LICENSE
as an additional source. (You could have written the URL with a tag if upstream
tagged releases, but they don’t, so the commit will have to do.) See
https://src.fedoraproject.org/rpms/rust-cyclonedx-bom-macros/blob/e0657f4c6db7c95437ed1a02fb99d7995d9ae272/f/rust2rpm.toml
for a similar example.

----

> BuildRequires:  pkgconfig(gtksourceview-5)

This appears to be correct, but these bindings will also need
pkgconfig(gtksourceview-5) as an install-time dependency: Rust -devel packages
are source-only, and any application that depends directly or indirectly on
this package will have a transitive need to link the gtksourceview-5 library.

Try this in rust2rpm.toml:

[requires]
build = [
    "pkgconfig(gtksourceview-5)",
]
lib = [
    "pkgconfig(gtksourceview-5)",
]


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2486075

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202486075%23c1

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to