https://bugzilla.redhat.com/show_bug.cgi?id=2464801
Gordon Messmer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #6 from Gordon Messmer <[email protected]> --- At least two rpmlint reports should be addressed: Number 1: The node modules bundle contains pre-built binaries. I believe this will require that the package dist-git includes a script that fetches the node_modules, strips them of binaries, and archives the result. pi-coding-agent.noarch: W: only-non-binary-in-usr-lib $ file node_modules_prod/@earendil-works/pi-tui/native/*/*/*/* node_modules_prod/@earendil-works/pi-tui/native/darwin/prebuilds/darwin-arm64/darwin-modifiers.node: Mach-O 64-bit arm64 bundle, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL> node_modules_prod/@earendil-works/pi-tui/native/darwin/prebuilds/darwin-x64/darwin-modifiers.node: Mach-O 64-bit x86_64 bundle, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL> node_modules_prod/@earendil-works/pi-tui/native/win32/prebuilds/win32-arm64/win32-console-mode.node: PE32+ executable for MS Windows 6.02 (DLL), ARM64, 3 sections node_modules_prod/@earendil-works/pi-tui/native/win32/prebuilds/win32-x64/win32-console-mode.node: PE32+ executable for MS Windows 6.00 (DLL), x86-64, 3 sections Number 2: pi-coding-agent.spec: W: no-%check-section The project site indicates that a test suite exists: "./test.sh # Run tests (skips LLM-dependent tests without API keys)". That should be run in the %check section. If that's not possible, the package should at least document why it isn't possible. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2464801 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202464801%23c6 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
