https://bugzilla.redhat.com/show_bug.cgi?id=2267321



--- Comment #26 from Neal Gompa <[email protected]> ---
Spec review:

> # The tools are GPLv2+. The library is LGPLv2+, see below.
> License:        GPL-2.0-or-later

This needs a "SourceLicense" stanza, since the source code is both.

> %package -n librtmp-devel
> Summary:        Files for librtmp development
> License:        LGPLv2+

License tag needs to be updated to SPDX.

> %autosetup -p1 -n %{name}-%{commit}

This can be simplified to "%autosetup -C -p1" unless you want to ship this in
EPEL.

> %make_build SYS=posix CRYPTO=GNUTLS SHARED=yes XCFLAGS="%{optflags}" 
> XLDFLAGS="%{build_ldflags}"

XCFLAGS should use "%{build_cflags}".


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2267321

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202267321%23c26

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to