https://bugzilla.redhat.com/show_bug.cgi?id=2484925
--- Comment #8 from Diego Herrera <[email protected]> --- (In reply to Withenoughcoffee from comment #7) > Hi, I ran the fedora-review on the packages and it noted that the spec file > has a patch file that isn't in the source RPM. > Yeah, my bad! The specfile link I provided was the head of the main branch where I was pushing changes, and I sent an extra commit to fix a failing test without updating this post's srpm... This time I locked the specific commit :thumbsup: > The summary should not end in a period. > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_dos_and_donts Fixed > It looks like eigen3 is linked statically so the Build requires should be a > eigen3-static not eigen3-devel. > https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static- > libraries:~: > text=Packages%20which%20explicitly%20need%20to%20link%20against%20the%20stati > c%20version%20MUST%20BuildRequire%3A%20foo%2Dstatic%2C%20so%20that%20the%20us > age%20can%20be%20tracked You are right! I thought that it didn't. Fixed > Consider adding a -l flag for pyproject_save_files > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#:~: > text=Declare%20that%20a%20missing%20license%20should%20terminate%20the%20buil > d%2E Done ;) --- Spec URL: https://codeberg.org/dherrerace/python-ml-dtypes-rpm/raw/commit/aa0768dfeab657e2db83278b3d6ed5d23fe63035/python-ml-dtypes.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/dherrera/onnx-devel/srpm-builds/10617749/python-ml-dtypes-0.5.4-5.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2484925 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202484925%23c8 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
