https://bugzilla.redhat.com/show_bug.cgi?id=2445516
Ben Beasley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #7 from Ben Beasley <[email protected]> --- (In reply to Benson Muite from comment #6) > Sorry, believe they are deterministic but not stable from release to release: > https://github.com/zlib-ng/zlib-ng/issues/2216 I would point out that identical compressed stream output across compressor versions for particular settings is not something that ought to be relied upon in general. It imposes unreasonable constraints on the implementation and prevents useful improvements. It was never formally guaranteed even by zlib as far as I know, but people have gotten used to it because the zlib implementation has been so stable (or stagnant, depending on how one sees it) for so many years. You will certainly see compressed streams changing from version to version in the reference implementations of other popular compression formats, like zstd. The package proposed here would (currently, implicitly) conflict with the zlib-ng-compat package, which causes all sorts of problems and isn’t generally allowed. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Conflicts/#_library_name_conflicts. It seems like this review is basically intended to suggest reverting https://fedoraproject.org/wiki/Changes/ZlibNGTransition, although I see that you mentioned (but did not implement) the idea of making the zlib implementation switchable using environment modules. I personally think that the right answer is to stop relying on the mostly-accidental stability of compressed data streams produced by the zlib reference encoder across releases, but *if* you feel there is adequate justification to reintroduce the reference zlib package and add the complexity of something like environment modules, it would be appropriate to engage the zlib-ng maintainers (since their package would also need changes to make this work), and to go through the System-Wide Changes process. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2445516 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202445516%23c7 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
