https://bugzilla.redhat.com/show_bug.cgi?id=2489101
--- Comment #3 from Ben Beasley <[email protected]> --- Thank you for the review! (In reply to Fabio Valentini from comment #2) > Package looks good to me, with one minor issue: > > There are two test files which are MIT-only licensed - it might make sense > to just %exclude all "*.graphql" files from "tests/" so the package License > tag doesn't need to be adapted to add "AND MIT" just because of test input > data: > > - tests/executables/kitchen-sink.graphql > - tests/services/kitchen-sink.graphql > > Since this is a simple change, I trust that you can do that before importing > the package. Good catch! Thank you. As you suggested, I will use exclude-crate-files in rust2rpm.toml to omit .graphql files from the binary packages. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2489101 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202489101%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
