https://bugzilla.redhat.com/show_bug.cgi?id=2488749
Nicolas Chauvet (kwizart) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|[email protected] |[email protected] CC| |[email protected] Flags| |fedora-review? --- Comment #2 from Nicolas Chauvet (kwizart) <[email protected]> --- Thanks for submitting the decklink package. Taking the review. Note, this is not the project I've suggested to package which is this one: https://gitlab.com/robUx4/decklink-oss.git as used in the vlc contrib code: https://code.videolan.org/videolan/vlc/-/blob/master/contrib/src/decklink/rules.mak?ref_type=heads However this decklink-oss version also provides older headers, likely for some other usage. As we might not need them, using the upstream vendor source might be a better way forward. The package name is arbitrary here, given Blackmagic_DeckLink_SDK_%{version}.zip is the original tarball name. My take is that SDK is not a standard keyword that properly describes what is distributed. I would use suggest to use the decklink package name that will drop a -headers noarch sub-package instead. That way, anything distributed in /usr/include are either -devel (when an symlink to an arched library is also required) or -headers when a noarch headers are provided. Except for compilers and others development related packages, this should be a good assumption. (I've used this -devel sub-package in the directx-headers package review). Formal review in progress... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2488749 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202488749%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
