https://bugzilla.redhat.com/show_bug.cgi?id=2463755
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|[email protected] |[email protected] CC| |[email protected] Status|NEW |ASSIGNED Flags| |fedora-review? --- Comment #3 from Fabio Valentini <[email protected]> --- Package looks mostly OK. Two minor things: - You shouldn't need to "install" the license files in %install manually. The "%cargo_install" macro should already handle this. - It would be nice if the Sources for LICENSE, LICENSE-APACHE, and README.md were actual URLs - that would make it obvious where they come from. They're correctly documented in the .spec file, but that's not machine-readable (and "spectool -g" can't download them if they're not URLs). In this case, the URLs would be: https://github.com/Abel981/abol/raw/83bbd1c/LICENSE https://github.com/Abel981/abol/raw/83bbd1c/LICENSE-APACHE https://github.com/Abel981/abol/raw/83bbd1c/README.md (Where 83bbd1c is the commit that was git HEAD when abol-util 0.1.0 was published.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2463755 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202463755%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
