https://bugzilla.redhat.com/show_bug.cgi?id=2487449
Petr Pisar <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|[email protected] |[email protected] CC| |[email protected] Flags| |fedora-review? --- Comment #1 from Petr Pisar <[email protected]> --- URL and Source0 addresses are usable. Ok. Source0 archive (SHA-512: b2527d95286b6767825b3003ea391154c42cb66eabb9b34df8f541095f1267056661e61eb442f097fca13fd4e7ac051539d1057861693a5139b700c8b6c16bd1) is original. Ok. Summary verified from Fuse3.pm. Ok. Description verified from Fuse3.pm. Ok. XS code found, fullarch BuildArch is Ok. License verified from Makefile.PL, README.md. FIX: Correct the license tag to `LGPL-2.1-only'. The README.md as well as the referred libfuse project <https://github.com/libfuse/libfuse/blob/master/LICENSE> requires a specific version without the "or later" phrase. FIX: Build-require `findutils' (perl-Filesys-Fuse3.spec:56). FIX: Build-require `pkgconf-pkg-config` (Makefile.PL:65). FIX: Build-require `pkgconfig(fuse3) >= 2.6) instead of `fuse3-devel' (Makefile.PL:132). TODO: Build-require `perl(:VERSION) >= 5.20' (Fuse3.pm:3). FIX: Build-require `perl(Test::Harness)' (test.pl:4). TODO: Unset FAKEROOTKEY and LOGNAME environment variables before executing the tests to make the tests deterministic. $ rpmlint perl-Filesys-Fuse3.spec ../SRPMS/perl-Filesys-Fuse3-0.021-1.fc45.src.rpm ../RPMS/x86_64/perl-Filesys-Fuse3-* ======================================== rpmlint session starts ======================================= rpmlint: 2.9.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 == 4 packages and 1 specfiles checked; 0 errors, 0 warnings, 17 filtered, 0 badness; has taken 0.6 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-Filesys-Fuse3-0.021-1.fc45.x86_64.rpm drwxr-xr-x 2 root root 0 Jun 10 02:00 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Jun 10 02:00 /usr/lib/.build-id/b6 lrwxrwxrwx 1 root root 67 Jun 10 02:00 /usr/lib/.build-id/b6/55b564ab810122991b9fcb6cd6f342dc52eec7 -> ../../../../usr/lib64/perl5/vendor_perl/auto/Filesys/Fuse3/Fuse3.so drwxr-xr-x 2 root root 0 Jun 10 02:00 /usr/lib64/perl5/vendor_perl/Filesys -rw-r--r-- 1 root root 28667 Apr 12 17:56 /usr/lib64/perl5/vendor_perl/Filesys/Fuse3.pm drwxr-xr-x 2 root root 0 Jun 10 02:00 /usr/lib64/perl5/vendor_perl/auto/Filesys drwxr-xr-x 2 root root 0 Jun 10 02:00 /usr/lib64/perl5/vendor_perl/auto/Filesys/Fuse3 -rwxr-xr-x 1 root root 73288 Jun 10 02:00 /usr/lib64/perl5/vendor_perl/auto/Filesys/Fuse3/Fuse3.so -rw-r--r-- 1 root root 92 Jun 10 02:00 /usr/lib64/perl5/vendor_perl/auto/Filesys/Fuse3/autosplit.ix drwxr-xr-x 2 root root 0 Jun 10 02:00 /usr/share/doc/perl-Filesys-Fuse3 -rw-r--r-- 1 root root 1106 Apr 5 14:46 /usr/share/doc/perl-Filesys-Fuse3/AUTHORS -rw-r--r-- 1 root root 397 Apr 12 17:55 /usr/share/doc/perl-Filesys-Fuse3/Changes -rw-r--r-- 1 root root 6976 Apr 5 16:52 /usr/share/doc/perl-Filesys-Fuse3/README.md drwxr-xr-x 2 root root 0 Apr 12 17:56 /usr/share/doc/perl-Filesys-Fuse3/examples -rw-r--r-- 1 root root 3122 Apr 5 15:05 /usr/share/doc/perl-Filesys-Fuse3/examples/example.pl -rw-r--r-- 1 root root 2555 Apr 5 15:05 /usr/share/doc/perl-Filesys-Fuse3/examples/example_t.pl -rw-r--r-- 1 root root 4580 Apr 5 15:05 /usr/share/doc/perl-Filesys-Fuse3/examples/fioc.pl -rw-r--r-- 1 root root 1721 Mar 28 18:11 /usr/share/doc/perl-Filesys-Fuse3/examples/fioclient.pl -rw-r--r-- 1 root root 5584 Apr 5 15:05 /usr/share/doc/perl-Filesys-Fuse3/examples/fsel.pl -rw-r--r-- 1 root root 770 Mar 28 18:11 /usr/share/doc/perl-Filesys-Fuse3/examples/fselclient.pl -rw-r--r-- 1 root root 9420 Apr 5 15:05 /usr/share/doc/perl-Filesys-Fuse3/examples/loopback.pl -rw-r--r-- 1 root root 1922 Apr 5 15:05 /usr/share/doc/perl-Filesys-Fuse3/examples/rmount.pl -rw-r--r-- 1 root root 3659 Mar 28 18:11 /usr/share/doc/perl-Filesys-Fuse3/examples/rmount_remote.pl -rw-r--r-- 1 root root 9866 Jun 10 02:00 /usr/share/man/man3/Filesys::Fuse3.3pm.gz File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Filesys-Fuse3-0.021-1.fc45.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.34)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libc.so.6(GLIBC_ABI_DT_RELR)(64bit) 1 libc.so.6(GLIBC_ABI_GNU2_TLS)(64bit) 1 libfuse3.so.4()(64bit) 1 libfuse3.so.4(FUSE_3.0)(64bit) 1 libfuse3.so.4(FUSE_3.17)(64bit) 1 libfuse3.so.4(FUSE_3.2)(64bit) 1 libperl.so.5.42()(64bit) 1 perl(:MODULE_COMPAT_5.42.2) 1 perl(:VERSION) >= 5.20.0 1 perl(AutoLoader) 1 perl(Carp) 1 perl(Config) 1 perl(constant) 1 perl(DynaLoader) 1 perl(Errno) 1 perl(Exporter) 1 perl(List::Util) 1 perl(strict) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-Filesys-Fuse3-0.021-1.fc45.x86_64.rpm | sort -f | uniq -c 1 perl(Filesys::Fuse3) = 0.021 1 perl-Filesys-Fuse3 = 0.021-1.fc45 1 perl-Filesys-Fuse3(x86-64) = 0.021-1.fc45 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-Filesys-Fuse3-0.021-1.fc45.x86_64.rpm Binary dependencies are resolvable. Ok. The package builds in F45 (https://koji.fedoraproject.org/koji/taskinfo?taskID=146971867). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the FIX items, consider fixing TODO items, and provide a new spec file. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2487449 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202487449%23c1 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
