https://bugzilla.redhat.com/show_bug.cgi?id=2491110
Ankur Sinha (FranciscoD) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #4 from Ankur Sinha (FranciscoD) <[email protected]> --- (In reply to Chenxiong Qi from comment #3) > (In reply to Ankur Sinha (FranciscoD) from comment #2) > > Looks very good. A few issues that are worth looking into: > > > > > > - rpmlint flags: > > > > python-exa-py.src: W: summary-ended-with-dot Python SDK for Exa API. > > python3-exa-py.noarch: W: summary-ended-with-dot Python SDK for Exa API. > > 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 7 filtered, 0 > > badness; has taken 0.6 s > > > > ^^^ > > minor issue, please remove the period at the end of the summary > > Fixed. +1 > > > > > - Latest version is packaged. > > ^^^ > > The latest version is 2.14.0---we should be packaging this. > > This package is built because of building hermes-agent 0.14.0, that pins at > exa-py 2.10.2. > exa-py will be updated to newer version when building newer versions of > hermes-agnet. The only place where they seem to use it is here: https://github.com/NousResearch/hermes-agent/blob/c93b9f9057e4d9db61ef3cabef59491bbfdbe5ec/plugins/web/exa/provider.py#L70 I think you can safely unpin it and test out hermes-agent. I dont' expect anything to break. It's sort of expected of us package maintainers to help upstream developers port their code to newer versions of libraries/dependencies---because newer versions include bugfixes/features. Also, this package, even if it's primarily being packaged for hermes-agent is a system-wide package that can be used by users and other packages---it's not a private package that is only consumed by hermes-agent. So, while the guidelines don't explicitly require it, it'll be good to package the latest release so that other users/packagers do get the benefits of bugfixes/enhancements. > > > > > - %check is present and all tests pass. > > ^^^ > > While the pypi tar does not include unit tests, the github tar does. I would > > recommend using that and running the unit tests. > > > > Upstream git repository does not have tag for version 2.10.2. This will be > fixed along with building newer version of hermes-agent. Cool. I may be a good idea to file a ticket asking upstream to consistently tag their git repo to match pypi releases too---it makes life a lot easier for downstream consumers. XXX APPROVED XXX -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2491110 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202491110%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
