https://bugzilla.redhat.com/show_bug.cgi?id=2366506
--- Comment #21 from Cristian Le <[email protected]> --- Aaand I forgot this was approved. Thanks for the review! > Requires: lief%{?_isa} = %{version}-%{releas Should not be needed because all of them arched? > c) One can build the examples and run some of them as a smoke test. A build > that does this: I would want to avoid this because I do not like packaging examples much. Will come back to it if enabling ctest is getting to hard > d) Consider building and packaging the documentation, these require sphinx > and doxygen. Sphinx documentation building is hard, especially with a project that locks all its dependencies like this one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2366506 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202366506%23c21 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
