https://bugzilla.redhat.com/show_bug.cgi?id=2467299
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review+ |fedora-review? Status|POST |ASSIGNED CC| |[email protected] --- Comment #4 from Fabio Valentini <[email protected]> --- I see at least one issue that should have blocked approval: The built packages are not all installable. In particular, the "cranelift" feature pulls in the cranelift compiler infrastructure, which isn't packaged for Fedora. That feature will need to be hidden (or cranelift needs to get packaged, if it's actually needed for aya). I would also recommend to persist the configuration for which tests are / can be run in a rust2rpm.toml config file. Both things can be achieved with a rust2rpm.toml file with these contents: ``` [features] hide = ["cranelift"] [tests] run = [ "lib", "test:assembler", "test:disassembler", "test:misc", "test:ubpf_verifier", "test:ubpf_vm", ] comments = [ """\ JIT tests (ubpf_jit_x86_64) and JIT doctests require mprotect(PROT_EXEC|PROT_WRITE) which is denied by SELinux deny_execmem policy in mock/Koji. Run lib unit tests + all safe integration tests, skip JIT and doctests.""", ] ``` see man(5) rust2rpm.toml for documentation of the config file format. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2467299 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202467299%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
