https://bugzilla.redhat.com/show_bug.cgi?id=2493314
Artur Frenszek-Iwicki <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #8 from Artur Frenszek-Iwicki <[email protected]> --- > %global debug_package %{nil} Nuh-uh. We want debuginfo in Fedora. https://docs.fedoraproject.org/en-US/packaging-guidelines/Debuginfo/ > Version: 1.0.0 > Release: 1.20260625235357766098.main.0.g2132ebbc6%{?dist} Snapshot info should be part of Version, not Release. Also, you don't need to make it so detailed. https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots > Source0: libxs-1.0.0.tar.gz This should, preferably, be a downloadable URL. https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ Since the project is hosted on GitHub, you can use the following: %global git_commit COMMIT_HASH_HERE Source0: https://github.com/hfp/libxs/archive/%{git_commit}/libxs-%{git_commit}.tar.gz Or, alternatively, you can use the Forge macros: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_commit_example > %files > %{_libdir}/libxs.so.* You should avoid using a catch-all wildcard here, as it will hide any SONAME changes. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files > %files devel > %license LICENSE.md As the devel package requires the main package, you don't need to package the licence here. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#subpackage-licensing -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2493314 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202493314%23c8 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
