https://bugzilla.redhat.com/show_bug.cgi?id=2463381
Ben Beasley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #9 from Ben Beasley <[email protected]> --- The source diff from the previous submission is: --- ../review-python-dotbot/srpm-unpacked/python-dotbot.spec 2026-04-28 08:25:53.000000000 +0100 +++ srpm-unpacked/python-dotbot.spec 2026-06-24 01:00:00.000000000 +0100 @@ -10,6 +10,7 @@ BuildArch: noarch BuildRequires: python3-devel +BuildRequires: python3-pytest %global _description %{expand: Dotbot makes installing your dotfiles as easy as @@ -38,10 +39,8 @@ %pyproject_install %pyproject_save_files -l dotbot -# Tests require a real home directory, filesystem symlink operations, -# and git, which are not available in the mock build environment. -# %%check -# %%pytest +%check +%pytest %files -n python3-dotbot -f %{pyproject_files} %doc README.md You only added pytest as a dependency, and it worked, so the pytest plugins weren’t really necessary, which is nice. You chose not to jump through the extra hoops to run test_shim (BR git-core and pass “-S git” to %autoseup), and you chose not to pass “-rs” to “%pytest” to print the reasons for skipped tests. All of this is acceptable, as you are now successfully running the great majority of tests: ================= 147 passed, 3 skipped, 78 warnings in 0.58s ================== You chose not to implement any of the suggestions from the “Notes” section. This is OK; they are only suggestions. There are no new and interesting diagnostics in the rpmlint output or the fedora-review template. I still think you should package CHANGELOG.md as documentation, too, but this doesn’t need to block the review. Based on the original review above plus a close inspection of the changes in the latest submission, this package is APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2463381 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202463381%23c9 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
