https://bugzilla.redhat.com/show_bug.cgi?id=2486945
--- Comment #4 from Iñaki Ucar <[email protected]> --- Spec URL: https://iucar.fedorapeople.org/pkgs/wavemon.spec SRPM URL: https://iucar.fedorapeople.org/pkgs/wavemon-0.9.7-1.fc45.src.rpm Thanks, modifications above. Comments: (In reply to wojnilowicz from comment #3) > Here are the issues that I found: > 1. iw_nl80211.h and iw_nl80211.c seem to be under ISC license and you don't > mention it. Done. > 2. How do you know it's GPL-3.0-only and not GPL-3.0-or-later? I created an > issue at https://github.com/uoaerg/wavemon/issues/143 and it's worth linking > it in your spec unless resolved. Thanks, done. > 3. Could you convert > BuildRequires: ncurses-devel > BuildRequires: libcap-devel > BuildRequires: libnl3-devel > according to > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > PkgConfigBuildRequires/ ? This is not mandatory, but ok. > 4. I believe it's about libcap-devel and not libpcap-devel requirement. The > first one gives "checking for cap_get_flag in -lcap... yes" and the second > one "checking for cap_get_flag in -lcap... no". It is indeed libcap instead of libpcap. Modified now. Since it is an unretirement and the package was reported as working fine before, I assumed dependencies were ok. Good catch. > 5. Could you modify > # Delete wrong placed doc files > to something like > # Delete wrong placed doc files (LICENSE and README.md) > ? Done. > The first impression is like why don't you move them to the right place > instead of deleting them. The corresponding macros in %files know where to put them without me having to enter the path manually, so fewer chances of messing up. > Could you review https://bugzilla.redhat.com/show_bug.cgi?id=2493698 in > return? Will do. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2486945 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202486945%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
