https://bugzilla.redhat.com/show_bug.cgi?id=2494850

Zbigniew JÄ™drzejewski-Szmek <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+
             Status|ASSIGNED                    |POST



--- Comment #1 from Zbigniew JÄ™drzejewski-Szmek <[email protected]> ---
> dedicated to provide
providing

> BuildSystem:   pyproject
Ah, the fancy stuff :)

Looks all good.

+ package name is OK
+ license is acceptable for Fedora (LGPG-3.0-only)
+ license is specified correctly
+ modern pyproject packaging is used
+ builds and installs OK
+ latest version
+ BR/R/P look OK
+ %check is present and passes

rpmlint:
python3-obspy.x86_64: E: spelling-error ('parsers', '%description -l en_US
parsers -> parser, parses, parers')
It's interesting that it knows "parser" but not "parsers".

python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/clients/fdsn/client.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/clients/fdsn/mass_downloader/__init__.py
644 /usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/clients/fdsn/mass_downloader/domain.py
644 /usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/clients/fdsn/mass_downloader/restrictions.py
644 /usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/clients/fdsn/routing/routing_client.py
644 /usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/clients/fdsn/tests/test_base_routing_client.py
644 /usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/clients/fdsn/tests/test_client.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/clients/fdsn/tests/test_eidaws_routing_client.py
644 /usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/clients/fdsn/tests/test_federator_routing_client.py
644 /usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/clients/fdsn/tests/test_wadl_parser.py
644 /usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/clients/fdsn/wadl_parser.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/clients/nrl/client.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/clients/seedlink/slclient.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/core/inventory/channel.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/core/inventory/inventory.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/core/inventory/network.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/core/inventory/response.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/core/inventory/station.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/core/inventory/util.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/core/tests/test_channel.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/core/tests/test_inventory.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/core/tests/test_network.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/core/tests/test_response.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/core/tests/test_station.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/geodetics/flinnengdahl.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/geodetics/tests/test_util_flinnengdahl.py
644 /usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/imaging/scripts/mopad.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/imaging/scripts/plot.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/imaging/scripts/scan.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/ah/tests/test_core.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/arclink/tests/test_inventory_xml.py
644 /usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/cmtsolution/__init__.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/cmtsolution/tests/__init__.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/cmtsolution/tests/test_core.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/cnv/tests/test_core.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/css/tests/test_core.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/css/tests/test_station.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/dmx/tests/test_core.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/gcf/core.py 644 /usr/bin/env
python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/gcf/tests/test_core.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/gse2/libgse2.py 644 /usr/bin/env
python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/gse2/paz.py 644 /usr/bin/env
python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/gse2/tests/test_bulletin.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/gse2/tests/test_core.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/gse2/tests/test_libgse1.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/gse2/tests/test_libgse2.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/gse2/tests/test_paz.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/hypodd/tests/__init__.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/iaspei/tests/__init__.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/kinemetrics/tests/__init__.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/kinemetrics/tests/test_core.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/mseed/scripts/recordanalyzer.py
644 /usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/mseed/tests/test_recordanalyzer.py
644 /usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/ndk/__init__.py 644 /usr/bin/env
python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/ndk/tests/test_ndk.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/nlloc/__init__.py 644 /usr/bin/env
python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/nlloc/tests/test_core.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/nlloc/tests/test_util.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/nordic/tests/test_nordic.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/reftek/tests/test_core.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/scardec/__init__.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/scardec/tests/__init__.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/scardec/tests/test_core.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/seiscomp/tests/test_core.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/seiscomp/tests/test_event.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/seiscomp/tests/test_inventory.py
644 /usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/stationtxt/__init__.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/stationtxt/tests/test_station_text_parsing.py
644 /usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/stationxml/tests/test_stationxml.py
644 /usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/wav/core.py 644 /usr/bin/env
python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/wav/tests/test_core.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/win/tests/test_core.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/xseed/scripts/dataless2resp.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/xseed/scripts/dataless2xseed.py
644 /usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/xseed/scripts/xseed2dataless.py
644 /usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/io/xseed/tests/test_scripts.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/scripts/flinnengdahl.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/scripts/print.py 644 /usr/bin/env
python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/scripts/reftekrescue.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/scripts/runtests.py 644 /usr/bin/env
python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/scripts/sds_html_report.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/scripts/tests/test_print.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/cross_correlation.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/detrend.py 644 /usr/bin/env
python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/invsim.py 644 /usr/bin/env
python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/rotate.py 644 /usr/bin/env
python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/spectral_estimation.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/tests/test_array_analysis.py
644 /usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/tests/test_calibration.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/tests/test_cpxtrace.py 644
/usr/bin/python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/tests/test_detrend.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/tests/test_differentiate_and_integrate.py
644 /usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/tests/test_filter.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/tests/test_freqattributes.py
644 /usr/bin/python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/tests/test_hoctavbands.py 644
/usr/bin/python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/tests/test_interpolation.py
644 /usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/tests/test_invsim.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/tests/test_konnoohmachi.py 644
/usr/bin/python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/tests/test_polarization.py 644
/usr/bin/python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/tests/test_regression.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/tests/test_rotate.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/tests/test_sonic.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/tests/test_spectral_estimation.py
644 /usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/tests/test_tf_misfit.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/tf_misfit.py 644 /usr/bin/env
python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/signal/util.py 644 /usr/bin/env
python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/taup/tests/test_misc.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/taup/tests/test_seismic_phase.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/taup/tests/test_slowness_model.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/taup/tests/test_split_model.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/taup/tests/test_tau.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/taup/tests/test_taup_geo.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/taup/tests/test_taup_plotting.py 644
/usr/bin/env python
python3-obspy.x86_64: E: non-executable-script
/usr/lib64/python3.15/site-packages/obspy/taup/tests/test_velocity_model.py 644
/usr/bin/env python

Those should probably be changed to %python3. I'm not sure why that is not
happending
automatically.

python3-obspy.x86_64: W: no-soname
/usr/lib64/python3.15/site-packages/obspy/lib/evresp.cpython-315-x86_64-linux-gnu.so
python3-obspy.x86_64: W: no-soname
/usr/lib64/python3.15/site-packages/obspy/lib/gcf.cpython-315-x86_64-linux-gnu.so
python3-obspy.x86_64: W: no-soname
/usr/lib64/python3.15/site-packages/obspy/lib/gse2.cpython-315-x86_64-linux-gnu.so
python3-obspy.x86_64: W: no-soname
/usr/lib64/python3.15/site-packages/obspy/lib/mseed.cpython-315-x86_64-linux-gnu.so
python3-obspy.x86_64: W: no-soname
/usr/lib64/python3.15/site-packages/obspy/lib/segy.cpython-315-x86_64-linux-gnu.so
python3-obspy.x86_64: W: no-soname
/usr/lib64/python3.15/site-packages/obspy/lib/signal.cpython-315-x86_64-linux-gnu.so
python3-obspy.x86_64: W: no-soname
/usr/lib64/python3.15/site-packages/obspy/lib/tau.cpython-315-x86_64-linux-gnu.so
Thyt's OK, those are plugins.

python3-obspy.x86_64: W: no-manual-page-for-binary obspy-dataless2resp
python3-obspy.x86_64: W: no-manual-page-for-binary obspy-dataless2xseed
python3-obspy.x86_64: W: no-manual-page-for-binary obspy-flinn-engdahl
python3-obspy.x86_64: W: no-manual-page-for-binary obspy-mopad
python3-obspy.x86_64: W: no-manual-page-for-binary obspy-mseed-recordanalyzer
python3-obspy.x86_64: W: no-manual-page-for-binary obspy-plot
python3-obspy.x86_64: W: no-manual-page-for-binary obspy-print
python3-obspy.x86_64: W: no-manual-page-for-binary obspy-reftek-rescue
python3-obspy.x86_64: W: no-manual-page-for-binary obspy-runtests
python3-obspy.x86_64: W: no-manual-page-for-binary obspy-scan
python3-obspy.x86_64: W: no-manual-page-for-binary obspy-sds-report
python3-obspy.x86_64: W: no-manual-page-for-binary obspy-xseed2dataless
python3-obspy.x86_64: W: hidden-file-or-dir
/usr/lib64/python3.15/site-packages/obspy/.coveragerc
python3-obspy.x86_64: W: files-duplicate
/usr/lib64/python3.15/site-packages/obspy/scripts/__init__.py
/usr/lib64/python3.15/site-packages/obspy/clients/__init__.py:/usr/lib64/python3.15/site-packages/obspy/imaging/scripts/__init__.py:/usr/lib64/python3.15/site-packages/obspy/io/__init__.py:/usr/lib64/python3.15/site-packages/obspy/io/alsep/pse/__init__.py:/usr/lib64/python3.15/site-packages/obspy/io/alsep/wt/__init__.py:(and
2 more)
All this is OK.

python3-obspy.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.15/site-packages/obspy/io/ah/tests/data/ah1.c
python3-obspy.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.15/site-packages/obspy/io/ah/tests/data/ah2.c
python3-obspy.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.15/site-packages/obspy/io/css/tests/data/css2ascii.c
I don't think this matter much.

Package is APPROVED. Two suggestions:
- %description
- 'env python'
Please consider changing those when importing.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2494850

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202494850%23c1

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to