https://bugzilla.redhat.com/show_bug.cgi?id=2463819



--- Comment #5 from Fabio Valentini <[email protected]> ---
Thanks, the links work now.

I see one minor issue and one medium-sized blocker:

Looks like you copy-pasted the rust2rpm.config from other abol-* crates to this
one, but it's actually not necessary here:
This top-level crate already includes all the files that are separately
included (LICENSE, LICENSE-APACHE, README.md).
Just drop the rust2rpm.toml config for additional source files, doc-files /
license-files overrides, and scripts.prep.pre.

It looks like this crate also includes some unused (?) files that are not
covered by the MIT / Apache-2.0 license under dictionaries/* - these all have
CC-BY-4.0 license headers. If they are indeed unused (I see no references to
them in "abol-0.1.0" crate sources), you either need to "rm" those files in
%prep (i.e. `rm -vr dictionaries/`) or exclude them from packaged crates (i.e.
add something like `%exclude %{crate_instdir}/dictionaries/` to the %files list
for the -devel subpackage). Settings for both are available in rust2rpm.toml
(scripts.prep.post or package.exclude-crate-files).


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2463819

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202463819%23c5

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new

Reply via email to