https://bugzilla.redhat.com/show_bug.cgi?id=2495869
Fabio Valentini <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ CC| |[email protected] Assignee|[email protected] |[email protected] Status|NEW |POST --- Comment #4 from Fabio Valentini <[email protected]> --- Package was generated with rust2rpm, simplifying the review. There are a bunch of files (justfile, todo.md, docs/*) that could be excluded from the built packages, but they all seem to be OK from a "distributable" perspective and don't cause any problems, so whether or not to do that is up to you (there's a "package.exclude-crate-files" setting in rust2rpm.toml for this kind of situation) and since the package looks OK as-is I won't block the review on it. The patch is justified and documented (the "svg" dependency is only used for the included example application, so it can be dropped safely). The license files are in a location / have file names that aren't correctly recognized by rust2rpm, the settings for overriding that heuristic are correctly used. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2495869 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202495869%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
