https://bugzilla.redhat.com/show_bug.cgi?id=2492931
--- Comment #3 from Petr Pisar <[email protected]> --- URL and Source0 addresses are usable. Ok. TODO: Replace "0.16" version string in Source0 with %{version} macro. It will help you rebasing the spec file to new upstream versions. Source archive (SHA512: f43d1ef5a40a7a4d108ff55f77d630cf324062d2af85e6691c445e0fa9fceb658bd105a000f887cd6e5d1f0b1edaa95b1245781783e714a1f3b628ac7a4489fd) is original. Ok. Summary verified in lib/Font/FreeType.pm. Ok. Description verified in lib/Font/FreeType.pm. Ok. Found licenses: Makefile.PL: GPL-1.0-or-later OR Artistic-1.0-Perl 5x7.bdf: LicenseRef-Fedora-Public-Domain t/data/Vera.ttf: Bitstream-Vera FreeType.xs: GPL-1.0-or-later OR Artistic-1.0-Perl lib/Font/FreeType.pm: GPL-1.0-or-later OR Artistic-1.0-Perl lib/Font/FreeType/Face.pm: GPL-1.0-or-later OR Artistic-1.0-Perl lib/Font/FreeType/Glyph.pm: GPL-1.0-or-later OR Artistic-1.0-Perl Licenses are Ok. TODO: Add SourceLicense tag naming all the licenses. XS code found, no noarch BuildArch is Ok. FIX: Build-require "coreutils" (perl-Font-FreeType.spec:44). TODO: Use plain "perl" command instead of "%{__perl}" macro (perl-Font-FreeType.spec:48). TODO: Replace "-exec rm -f {} ';'" with "-delete" arguments in the first find command (perl-Font-FreeType.spec:54). FIX: Remove the second find comamnd, ExtUtils::MakeMaker does not create empty directories anymore (perl-Font-FreeType.spec:55). TODO: Package ./examples with %doc macro. TODO: Constrain "perl(ExtUtils::MakeMaker)" build dependency with ">= 6.76" as it is the first one version supporting NO_PACKLIST and NO_PERLLOCAL arguments. FIX: Build-require "perl(File::Spec::Functions)" (Makefile.PL:3). FIX: Build-require "perl(Carp)" (lib/Font/FreeType.pm:11). FIX: Build-require "perl(DynaLoader)" (lib/Font/FreeType.pm:7). FIX: Build-require "perl(strict)" (lib/Font/FreeType.pm:3). FIX: Build-require "perl(warnings)" (lib/Font/FreeType.pm:2). FIX: Build-require "make" (perl-Font-FreeType.spec:49). FIX: Build-require "freetype-devel" instead of "pkgconfig(freetype2)" (Makefile.PL:11). FIX: Build-require "perl(Test::More)" (t/05library.t:6). FIX: Build-require "perl(utf8)" (t/10metrics_verasans.t:10). FIX: Build-require "perl(version)" (t/10metrics_verasans.t:15). TODO: Dot not use globs at the top level of %{perl_vendorarch} and %{_mandir}/man3 paths in %files section. Those paths needs to be listed explicitly (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists). All tests pass. Ok. $ rpmlint perl-Font-FreeType.spec ../SRPMS/perl-Font-FreeType-0.16-1.fc45.src.rpm ../RPMS/x86_64/perl-Font-FreeType-* ======================================== rpmlint session starts ======================================= rpmlint: 2.9.0 configuration: /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 perl-Font-FreeType.x86_64: E: spelling-error ('antialiasing', '%description -l en_US antialiasing -> anti aliasing, anti-aliasing, instantiating') perl-Font-FreeType.src: E: spelling-error ('antialiasing', '%description -l en_US antialiasing -> anti aliasing, anti-aliasing, instantiating') == 4 packages and 1 specfiles checked; 2 errors, 0 warnings, 13 filtered, 2 badness; has taken 0.6 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-Font-FreeType-0.16-1.fc45.x86_64.rpm drwxr-xr-x 2 root root 0 Jul 2 02:00 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Jul 2 02:00 /usr/lib/.build-id/69 lrwxrwxrwx 1 root root 70 Jul 2 02:00 /usr/lib/.build-id/69/6d2ca5d4f07b2608d3e58081a0f4c7b77e296e -> ../../../../usr/lib64/perl5/vendor_perl/auto/Font/FreeType/FreeType.so drwxr-xr-x 2 root root 0 Jul 2 02:00 /usr/lib64/perl5/vendor_perl/Font drwxr-xr-x 2 root root 0 Jul 2 02:00 /usr/lib64/perl5/vendor_perl/Font/FreeType -rw-r--r-- 1 root root 7513 May 12 2020 /usr/lib64/perl5/vendor_perl/Font/FreeType.pm -rw-r--r-- 1 root root 1209 Mar 17 2018 /usr/lib64/perl5/vendor_perl/Font/FreeType/BoundingBox.pm -rw-r--r-- 1 root root 2162 Oct 19 2019 /usr/lib64/perl5/vendor_perl/Font/FreeType/CharMap.pm -rw-r--r-- 1 root root 10105 May 11 2020 /usr/lib64/perl5/vendor_perl/Font/FreeType/Face.pm -rw-r--r-- 1 root root 13702 May 11 2020 /usr/lib64/perl5/vendor_perl/Font/FreeType/Glyph.pm -rw-r--r-- 1 root root 1238 Mar 17 2018 /usr/lib64/perl5/vendor_perl/Font/FreeType/NamedInfo.pm drwxr-xr-x 2 root root 0 Jul 2 02:00 /usr/lib64/perl5/vendor_perl/auto/Font drwxr-xr-x 2 root root 0 Jul 2 02:00 /usr/lib64/perl5/vendor_perl/auto/Font/FreeType -rwxr-xr-x 1 root root 75112 Jul 2 02:00 /usr/lib64/perl5/vendor_perl/auto/Font/FreeType/FreeType.so drwxr-xr-x 2 root root 0 Jul 2 02:00 /usr/share/doc/perl-Font-FreeType -rw-r--r-- 1 root root 5600 May 12 2020 /usr/share/doc/perl-Font-FreeType/Changes -rw-r--r-- 1 root root 3935 Mar 17 2018 /usr/share/doc/perl-Font-FreeType/TODO drwxr-xr-x 2 root root 0 Jul 2 02:00 /usr/share/licenses/perl-Font-FreeType -rw-r--r-- 1 root root 6321 Jul 2 02:00 /usr/share/licenses/perl-Font-FreeType/Artistic -rw-r--r-- 1 root root 12522 Jul 2 02:00 /usr/share/licenses/perl-Font-FreeType/Copying -rw-r--r-- 1 root root 3801 Jul 2 02:00 /usr/share/man/man3/Font::FreeType.3pm.gz -rw-r--r-- 1 root root 1415 Jul 2 02:00 /usr/share/man/man3/Font::FreeType::BoundingBox.3pm.gz -rw-r--r-- 1 root root 1713 Jul 2 02:00 /usr/share/man/man3/Font::FreeType::CharMap.3pm.gz -rw-r--r-- 1 root root 4679 Jul 2 02:00 /usr/share/man/man3/Font::FreeType::Face.3pm.gz -rw-r--r-- 1 root root 5310 Jul 2 02:00 /usr/share/man/man3/Font::FreeType::Glyph.3pm.gz -rw-r--r-- 1 root root 1459 Jul 2 02:00 /usr/share/man/man3/Font::FreeType::NamedInfo.3pm.gz File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Font-FreeType-0.16-1.fc45.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libc.so.6(GLIBC_ABI_DT_RELR)(64bit) 1 libc.so.6(GLIBC_ABI_GNU2_TLS)(64bit) 1 libfreetype.so.6()(64bit) 1 libperl.so.5.42()(64bit) 1 perl(:MODULE_COMPAT_5.42.2) 1 perl(Carp) 1 perl(DynaLoader) 1 perl(Font::FreeType::Glyph) 1 perl(strict) 1 perl(warnings) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) FIX: Run-require "perl(Image::Magick)" (lib/Font/FreeType/Glyph.pm:78). $ rpm -q --provides -p ../RPMS/x86_64/perl-Font-FreeType-0.16-1.fc45.x86_64.rpm | sort -f | uniq -c 1 perl(Font::FreeType) = 0.16 1 perl(Font::FreeType::BoundingBox) 1 perl(Font::FreeType::CharMap) 1 perl(Font::FreeType::Face) 1 perl(Font::FreeType::Glyph) 1 perl(Font::FreeType::NamedInfo) 1 perl-Font-FreeType = 0.16-1.fc45 1 perl-Font-FreeType(x86-64) = 0.16-1.fc45 Binary Provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-Font-FreeType-0.16-1.fc45.x86_64.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora Rawhide (https://koji.fedoraproject.org/koji/taskinfo?taskID=147306606). Ok. Otherwise, the package is in line with Fedora and Perl packaging guidelines. Please correct the FIX items, consider fixing TODO items, and provide an updates spec file. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2492931 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202492931%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
