https://bugzilla.redhat.com/show_bug.cgi?id=2496719
--- Comment #3 from [email protected] --- Spec URL: https://trix.fedorapeople.org/migraphx7.2.spec SRPM URL: https://trix.fedorapeople.org/migraphx7.2-7.2.2-2.fc45.src.rpm >> # blake3 is not used in the build >> ... >> # Not used in the build > > So why not just remove it in %prep? > > The licensing is a bit of a confusing mess, if you can delete any files you > don't need in prep, it would make it much easier to review. > It's a big PITA when projects bundle LLVM, but it is what it is. Turns out it is needed. %prep already had removal of unneeded things. I add this comment to cover trying to remove blake3 # try to remove blake3 # rm -rf external/llvm-project/llvm/lib/Support/BLAKE3 # sed -i -e 's@add_subdirectory(BLAKE3)@#add_subdirectory(BLAKE3)@' external/llvm-project/llvm/lib/Support/CMakeLists.txt # sed -i -e '/LLVMSupportBlake3/d' external/llvm-project/llvm/lib/Support/CMakeLists.txt # # Leads to # ld.lld: error: undefined symbol: llvm_blake3_hasher_finalize I know removing other would make the license simpler but removing random files in llvm is itself complicated and error prone. Keeping the documentation as-is is the lower risk. >> # Test infra not shipped > > Ok but is it used in %check? I think the rule is, if it's delete-able, then > it's ignore-able. > I see you wrapped %check in a condition. I assume the unit tests can't be run > right? Unit tests are not installable, that is why there is a %check. But also depends on a gpu so %check isn't suitable for most cases. Added some comments here # Needs to run on machine with a GPU # Built tests are not installed %bcond_with check %if %{with check} %global build_test ON %else %global build_test OFF %endif -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2496719 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202496719%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
