https://bugzilla.redhat.com/show_bug.cgi?id=2497173
Mamoru TASAKA <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #2 from Mamoru TASAKA <[email protected]> --- A couple of notes: * I don't see why BR: desktop-file-utils is needed here * Use BuildRequires: pkgconfig(gtk+-3.0) (see configure.ac), optionally BuildRequires: pkgconfig(gthread-2.0) as well (not strictly needed) * With above, BR: pkgconfig is unneeded. * %{_includedir}/dialsys.h must be in -devel package * Please include AUTHORS as %doc . * Verify the license tag: as far as I checked this, this should be License: GPL-3.0-or-later AND GPL-2.0-only (please actually check the files in the tarball) Also, my recognition is that GPL-3.0-or-later and GPL-2.0-only are incompatible. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2497173 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202497173%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
