https://bugzilla.redhat.com/show_bug.cgi?id=2269731
Ben Beasley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(code@musicinmybra | |in.net) | --- Comment #15 from Ben Beasley <[email protected]> --- I’m sorry, but I am not sure I actually wanted to review this, which is why I did not assign it to myself. I am not entirely comfortable providing good feedback on the privilege escalation approaches via polkit and udev, at least within the time I have available. /usr/share/polkit-1/actions/com.gitlab.CameronNemo.brillo.policy is described upstream as “Active sessions can invoke brillo via pkexec to escalate priveleges.” <?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE policyconfig PUBLIC "-//freedesktop//DTD PolicyKit Policy Configuration 1.0//EN" "http://www.freedesktop.org/standards/PolicyKit/1.0/policyconfig.dtd";> <policyconfig> <vendor>com.gitlab.CameronNemo</vendor> <vendor_url>https://gitlab.com/CameronNemo/brillo</vendor_url> <action id="com.gitlab.CameronNemo.pkexec.brillo"> <description>Control the brightness of backlight and keyboard LED devices</description> <defaults> <allow_any>no</allow_any> <allow_inactive>no</allow_inactive> <allow_active>yes</allow_active> </defaults> <annotate key="org.freedesktop.policykit.exec.path">/usr/bin/brillo</annotate> </action> </policyconfig> /usr/lib/udev/rules.d/92-com.gitlab.CameronNemo.brillo.rules is described as “brillo's udev rule grants necessary permissions to the video group for backlight and keyboard LED devices.” ACTION=="add", SUBSYSTEM=="backlight", RUN+="/bin/chgrp video /sys/class/backlight/%k/brightness" ACTION=="add", SUBSYSTEM=="backlight", RUN+="/bin/chmod g+w /sys/class/backlight/%k/brightness" ACTION=="add", SUBSYSTEM=="leds", RUN+="/bin/chgrp video /sys/class/leds/%k/brightness" ACTION=="add", SUBSYSTEM=="leds", RUN+="/bin/chmod g+w /sys/class/leds/%k/brightness" -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2269731 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202269731%23c15 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
