https://bugzilla.redhat.com/show_bug.cgi?id=2497531
Jitka Plesnikova <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Jitka Plesnikova <[email protected]> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok $ rpm -qp --requires perl-B-Hooks-AtRuntime-8-14.fc45.x86_64.rpm | sort | uniq -c | grep -v rpmlib 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libc.so.6(GLIBC_ABI_DT_RELR)(64bit) 1 libc.so.6(GLIBC_ABI_GNU2_TLS)(64bit) 1 perl(Carp) 1 perl(constant) 1 perl(Exporter::Tiny) 1 perl-libs 1 perl(:MODULE_COMPAT_5.42.2) 1 perl(parent) 1 perl(strict) 1 perl(Sub::Name) 1 perl(warnings) 1 perl(XSLoader) 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -qp --provides perl-B-Hooks-AtRuntime-8-14.fc45.x86_64.rpm | sort | uniq -c 1 perl(B::Hooks::AtRuntime) = 8 1 perl-B-Hooks-AtRuntime = 8-14.fc45 1 perl-B-Hooks-AtRuntime(x86-64) = 8-14.fc45 Binary provides are Ok. $ rpmlint ./perl-B-Hooks-AtRuntime* perl-B-Hooks-AtRuntime.x86_64: E: zero-length /usr/lib64/perl5/vendor_perl/auto/B/Hooks/AtRuntime/AtRuntime.bs 2 packages and 1 specfiles checked; 1 errors, 0 warnings, 8 filtered, 1 badness; has taken 0.4 s FIX: Remove the zero-length .bs file. Add to %install section: find %{buildroot} -type f -name '*.bs' -empty -delete TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please consider fixing 'FIX' and 'TODO' items. Resolution: Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2497531 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202497531%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
