https://bugzilla.redhat.com/show_bug.cgi?id=2497525
Jitka Plesnikova <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Status|NEW |ASSIGNED CC| |[email protected] Assignee|[email protected] |[email protected] --- Comment #2 from Jitka Plesnikova <[email protected]> --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok FIX: Add build-require 'coreutils' - it is needed for %{_fixperms} TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 NO_PACKLIST is provided since this version. $ rpm -qp --requires perl-Proc-Wait3-0.05-37.fc45.x86_64.rpm | sort | uniq -c | grep -v rpmlib 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libc.so.6(GLIBC_ABI_DT_RELR)(64bit) 1 libc.so.6(GLIBC_ABI_GNU2_TLS)(64bit) 1 libperl.so.5.42()(64bit) 1 perl(DynaLoader) 1 perl(Exporter) 1 perl-libs 1 perl(:MODULE_COMPAT_5.42.2) 1 perl(strict) 1 perl(:VERSION) >= 5.6.0 1 perl(warnings) 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -qp --provides perl-Proc-Wait3-0.05-37.fc45.x86_64.rpm | sort | uniq -c 1 perl(Proc::Wait3) = 0.05 1 perl-Proc-Wait3 = 0.05-37.fc45 1 perl-Proc-Wait3(x86-64) = 0.05-37.fc45 Binary provides are Ok. $ rpmlint ./perl-Proc-Wait3* perl-Proc-Wait3.x86_64: E: incorrect-fsf-address /usr/share/licenses/perl-Proc-Wait3/LICENSE 2 packages and 1 specfiles checked; 1 errors, 0 warnings, 8 filtered, 1 badness; has taken 0.4 s TODO: The incorrect FSF address is in the upstream LICENSE file, it should be report to upstream TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorarch} directories https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct 'FIX' item and consider fixing 'TODO' items. Resolution: Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2497525 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202497525%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
