https://bugzilla.redhat.com/show_bug.cgi?id=2498325
--- Comment #2 from Laudin Molina <[email protected]> --- Previous review request from 2015, abandoned by the original submitter. This request considers the comments in that request. Bundled libraries (declared): Provides: bundled(gzip) = 1.3.12 Provides: bundled(bzip2-old) = 0.9.5d Provides: bundled(bzip2) = 1.0.6 Rationale: patched/legacy compressor snapshots needed to regenerate byte-identical historical tarballs (old gzip/bzip2/SUSE-bzip2 builds), linking against current system libraries would not reproduce the same byte-for-byte output. See previous discussion https://bugzilla.redhat.com/show_bug.cgi?id=1235404#c5 rpmlint issues: - pristine-tar.src: E: spelling-error ('gz', '%description -l en_US gz -> g, z, gr') False positive -- "gz" is the gzip file extension not a misspelling. - pristine-tar.x86_64: E: spelling-error ('gz', '%description -l en_US gz -> g, z, gr') False positive -- "gz" is the gzip file extension not a misspelling. - pristine-tar.spec: W: no-%check-section The test suite requires shunit2 (not in $PATH on Fedora, see https://bugzilla.redhat.com/show_bug.cgi?id=2494102) and diffoscope (uninstallable on Fedora 44 due to a dependency conflict, see https://bugzilla.redhat.com/show_bug.cgi?id=2464627). The spec files includes the relevant sections commented. - pristine-tar.x86_64: E: incorrect-fsf-address /usr/share/licenses/pristine-tar/GPL-2.0-or-later.txt False positive on verbatim upstream license text. The license file uses "51 Franklin Street" FSF address, which matches https://spdx.org/licenses/GPL-2.0-or-later.html. Other issues: - Runtime dependency on perl(Sys::CpuAffinity) that is not yet in Fedora - pending review. See https://bugzilla.redhat.com/show_bug.cgi?id=2425545. Filing this review in parallel rather than blocking on it. This is my first package under review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2498325 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202498325%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
