https://bugzilla.redhat.com/show_bug.cgi?id=2497962
--- Comment #12 from [email protected] --- Spec URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/2.0.0/sckoc.spec SRPM URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/2.0.0/sckoc-2.0.0-1.fc44.src.rpm Changes since the previous submission: - %install was shipping the compiled `readoc` helper as %{_bindir}/sckoc, and the actual monitor script was not packaged at all. Fixed: the script is now installed as %{_bindir}/sckoc and the compiled helpers as %{_libexecdir}/sckoc/{readoc,hsmp-msg}. - Removed an inaccurate statement in %description claiming derivation from intel/msr-tools — all code in this package is original work (License: GPL-2.0-only, unchanged). - %build now uses %set_build_flags + %make_build so distribution compiler and linker flags apply to both helpers. - Added %check smoke tests (script parse check, readoc -V) that would have caught the mispackaging. - Added Requires: kmod (the script probes optional kernel modules at runtime) and co-owned the bash-completion directories. - Note: the upstream 2.0.0 tag was re-cut to include these fixes (the package has never shipped in Fedora), so the Source0 tarball checksum changed intentionally. rpmlint: 5 errors, 2 warnings. The five spelling-error hits (dev, cpu, msr, hsmp, amd) are dictionary false positives on device paths and kernel module names quoted verbatim in %description (/dev/cpu/*/msr, /dev/hsmp, amd_hsmp). The two specfile-warnings are a missing en_US.UTF-8 locale in the build container, unrelated to the spec. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2497962 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202497962%23c12 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
